[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-5108) JBossRuntimeManager has hard-coded the configuration to default

[Denny Xu (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-5108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12491995#action_12491995 ] 

Denny Xu commented on JBIDE-5108:
---------------------------------

Basically, the JBossRuntimeManager doesn't care about what the configuration is, the only thing it does is to get ESB runtime jars from a given location,
the location may be a standalone ESB runtime, SOA-P , EAP and also can be a location of JBossAS with ESB runtime get installed, what does JBossRuntimeManager do is to get the locations of "jbossesb.esb" and "jbossesb.sar" and then pick up jars from the locations and add jars to the 
project ClassPath, it doesn't depend on the any Server IRuntime object and it should require have to configure a JBoss Server Runtime at the beginning, 
in other worlds,  one ESB runtime doesn't mean there should be  a corresponding JBoss Server Runtime.

The only issue is that if the user use community JBoss AS and get ESB runtime installed to non-default configuration, it would not get the esb runtime 
location,  so maybe scan all available configurations is a good choice.

"Also the same class has the following if statement twice: "

the two statement is not the same, the first one means if the esbPath is not exist then try to consider the location is a ESB standalone location, 
the second one means if the location is not a standalone ESB then treat it as a SOAP location.

> JBossRuntimeManager has hard-coded the configuration to default
> ---------------------------------------------------------------
>
>                 Key: JBIDE-5108
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-5108
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: esb
>    Affects Versions: 3.1.0.M3
>            Reporter: Rob Stryker
>            Assignee: Denny Xu
>            Priority: Critical
>             Fix For: 3.1.0.CR1
>
>
> The class has the following code:
> 		IPath soapDeployPath = rtHome.append(SOAP_AS_LOCATION).append("server").append("default").append("deploy");
> 		IPath deployPath = rtHome.append("server").append("default").append("deploy");
> These are incorrect if the runtime configuration is not default or if some other preferences have been set to change the location.  You should instead adapt the IRuntime into a IJBossServerRuntime (if possible) and then call getConfigurationFullPath().append(IJBossRuntimeResourceConstants.DEPLOY);
> Also the same class has the following if statement twice:
> 		if (!esbPath.toFile().exists() || !sarPath.toFile().exists()) {
> 			esbPath = libPath.append(JBOSSESB_ESB);
> 			sarPath = libPath.append(JBOSSESB_SAR);
> 		}
> 		
> 		if (!esbPath.toFile().exists() || !sarPath.toFile().exists()) {
> 			esbPath = soapDeployPath.append(JBOSSESB_ESB);
> 			sarPath = soapDeployPath.append(JBOSSESB_SAR);
> 		}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira