[jbosstools-issues] [JBoss JIRA] Resolved: (JBIDE-3915) jBPM Eclipse plugin can't save graphical view if gpd.xml is marked as read only

[Koen Aers (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBIDE-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koen Aers resolved JBIDE-3915.
------------------------------

    Resolution: Done


As a matter of fact, your statement about standard behaviour was not correct: the Java editor as well as the properties and plugin.xml editors in Eclipse (to name a few) just silently disallow keyboard and mouse input when opening readonly files. So their behaviour is that of a viewer, as I would expect. 

I investigated a little bit on how to implement this for my editor but I did not find any good way of changing the behaviour of a GEF editor to act as a viewer and I don't want to spend too much energy on this issue either. 

I have added a check for readonly files both on opening and saving the process definition and I offer to convert them into read-write. If they are not converted nothing is saved. The changes are in trunk and should appear in nightly builds.

> jBPM Eclipse plugin can't save graphical view if gpd.xml is marked as read only
> -------------------------------------------------------------------------------
>
>                 Key: JBIDE-3915
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-3915
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: jbpm
>    Affects Versions: 3.0.0.GA
>         Environment: Windows xp
> Eclipse 3.3.2
> jPDL Eclipse plugin v3.1.3 SP2
>            Reporter: Hedley Proctor
>            Assignee: Koen Aers
>             Fix For: 3.1.0.M4
>
>
> Usually when you get files out of a source control system, they will be marked as read only. So if you are editing a Java file in Eclipse, you will get a dialog box coming up asking you to make the file writable. Now consider what happens with jBPM:
> Most likely you will check in the gpd.xml file. Otherwise, other people trying to view your processdefinition.xml file will not get a very viewable image. (Everything will appear in the top left.)
> When you start editing your processdefinition.xml file, the picture you see will be updated. Everything will appear to be fine. However, none of the changes are saved to the gpd.xml file. When you shutdown Eclipse and restart, the gpd.xml will be out of step with the processdefinition.xml.
> I think this could be fixed fairly easily with a couple of lines of code that check the writable status of the gpd.xml file and change it if necessary. Obviously the workaround is just to manually change the write flag, but it is a bit of a "gotcha" and can lead to work being lost if you don't know to do that. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira