[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-4873) Various issues with hibernate mapping diagram

[Vitali Yemialyanchyk (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12485689#action_12485689 ] 

Vitali Yemialyanchyk commented on JBIDE-4873:
---------------------------------------------

2) - clause to discuss - cause it is possible to show the item -> from Outline view - popup menu - so as I think this is correct name; there is a contra for my prev statemant - this is not so obvious... so will be nice to hear your opinion;
4) - as I think Undo and Redo are excessive here; if no selected item on the Diagram - "Toggle expand state" & "Toggle visible state" should be disabled;
5) Undo and Redo toolbar buttons were in prev. version - I vote to remove it;
6) I do not sure are "Rulers", "Grid" and "Snap to Geometry" so important to insert it in the context menu... The example which inspire me for these nice features has these options only in View menu. If you in doubt about this - I prefere to leave this unchanged;
7) "Export as image" - to discuss this I check how it look in Linux, currently for Windows it seems correct to have possibility to save image outside of workspace, in Linux it's propose to save into user home folder - seems also correct; my point is to propose browse around cause this picture more necessary out of project workspace usage;
8) ok, I'll change names;
>>>
9) Have a "Show..." sub menu which have toggles for "Property Mappings" (property->column), "Class Mappings" (class->table), "Associations" (class associations), "Foreign key constraints" (foreign keys which associations are based on) 
not sure if the menu should be called "show" though....maybe look around for a better name in similar editors ? 
>>>
for sub menu name I'd like something like "Show connections" or "Switch on connections" or "Connections visibility" (currently my favorite name); should be in View menu and in popup menu, may be on tollbar (why not?);
 "Property Mappings", "Class Mappings", "Associations", "Foreign key constraints" - should be menu items with checkbox;


> Various issues with hibernate mapping diagram
> ---------------------------------------------
>
>                 Key: JBIDE-4873
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-4873
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Hibernate
>    Affects Versions: 3.1.0.M3
>            Reporter: Max Rydahl Andersen
>            Assignee: Vitali Yemialyanchyk
>            Priority: Critical
>             Fix For: 3.1.0.M4
>
>
> 1) New Icons used for layout, visibility, etc. are not transparent and meaning they all look very white since they also are 100% black/white opposite to all other icons used.
> 2) "Toggle Visible" state ? How do you untoggle that if you can't see the item ? Shouldn't it not just be a "Hide" option ?
> 3) The buttons in the toolbar all seem to be enabled even though they can't be used on everything
> 4) Why are there so many buttons in the toolbar anyway for this editor ? 
> 5) Why are the specific buttons for undo/redo when default undo/redo should suffice ?
> 6) Shouldn't the items in the View menu also be available from right click on the editor 
> 7) Can't we make Export as image save inside the workspace instead of having to browse around for it in a native dialog ?
> 8) Instead of "Toggle X" can't we make the action name update according to what it will do ? "i.e. Show|Hide, Show Connections/Hide Connection, Expand|Collapse, etc.
> (sorry for creating one big issue, if needed please split out)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira