[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-6148) org.jboss.tools.tests requires org.jboss.tools.jst

[Rob Stryker (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12523914#action_12523914 ] 

Rob Stryker commented on JBIDE-6148:
------------------------------------

While I have attached one possible patch, I do not believe this is the proper fix. The proper fix is to move the AbstractResourceMarkerTest to a plugin that it is more appropriate for.

or it should be made to not reference that constant entirely. 

> org.jboss.tools.tests requires org.jboss.tools.jst
> --------------------------------------------------
>
>                 Key: JBIDE-6148
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-6148
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>    Affects Versions: 3.1.0.GA
>            Reporter: Rob Stryker
>            Assignee: Denis Golovin
>            Priority: Critical
>         Attachments: JBIDE-6148.patch
>
>
> I find it unacceptable that org.jboss.tools.tests requires org.jboss.tools.jst.web.etc. 
> This means to test my jmx tools, or archive tools, I must import org.jboss.tools.test, which then means I must import org.jboss.tools.jst and all of *IT'S* requirements. 
>  org.jboss.tools.jst.web,
>  org.jboss.tools.common.el.core,
>  org.jboss.tools.common.text.ext,
>  org.jboss.tools.common.el.ui
> There is only one class that requires this dependency, and that is AbstractResourceMarkerTest.
> Possible solutions are to either copy the constant from jst.web.kb into the test plugin, or move the abstract class into a more appropriate plugin. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira