[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-6901) Expanding in Smooks Java Bean Instance dialog affects how bean is inserted

[Brian Fitzpatrick (JIRA)]

    [ https://jira.jboss.org/browse/JBIDE-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12547280#action_12547280 ] 

Brian Fitzpatrick commented on JBIDE-6901:
------------------------------------------

I agree with Jiri and have always had an issue with how that dialog worked.

By default, in Eclipse, every checkbox treeviewer I've seen has had this behavior:

* You can check the box beside an item with children and all its children (and its children, ad nauseum) are selected
* If you uncheck a box beside an item with children, all its children (and their children, etc.) are unselected
* If you uncheck a box deeper than the root level without children you end up with a state where you need to watch all check/uncheck states for each item down the line

In your dialog, it has followed this behavior:

* If you check the first box and don't expand it, you only get the first item
* If you expand an item and check the parent, you get only the expanded children beneath it

You should have a consistent behavior for this dialog that follows the Eclipse standard. 

That said, if you have an issue with circular dependencies within the treeviewer, you should reexamine your content provider and verify that a particular java class/schema element/xml element hasn't already been selected. This should be doable within the content provider. 

> Expanding in Smooks Java Bean Instance dialog affects how bean is inserted
> --------------------------------------------------------------------------
>
>                 Key: JBIDE-6901
>                 URL: https://jira.jboss.org/browse/JBIDE-6901
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: smooks
>    Affects Versions: 3.2.0.M2
>         Environment: JBT 3.2.0 M2, Linux 64
>            Reporter: Jiri Peterka
>            Assignee: Xue Peng
>             Fix For: 3.2.0.Beta
>
>         Attachments: smooks-bean-dlg.png, smooks-bean-expanding.png
>
>   Original Estimate: 0 minutes
>  Remaining Estimate: 0 minutes
>
> Steps:
> 1. Have Java Mapping task in smooks-config editor 
> 2. Add Java Class on canvas
> 3. Select composited bean class (like Order - containing OrderItem, Header) or any other class composed like that
> 4. Click OK
> 5. Try to do it again with expanding (and/or collapsing)  tree in the dialog. Let everything checked as it is
> ASSERT: Result should be the same
> ASSERT: Both steps should result to expanded model on canvas (as it seems to be selected by default)
> Note: Possibly linked with https://jira.jboss.org/browse/JBIDE-5358

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira