[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-7681) Cannot create two or more top down web services in a web project

[Brian Fitzpatrick (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-7681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570558#comment-12570558 ] 

Brian Fitzpatrick commented on JBIDE-7681:
------------------------------------------

Ok, so Lukas' patch works to a point to get around the issue of multiple WS in a project using the WTP Web Service wizard. 

The issues that I can find at this point are:

1) For a non-real-world test case, if you add a web service via WSDL that's already been added to a project (i.e. implementation classes generated and servlet definitions created in the web.xml), it will get as far as generating the implementation classes again (overwriting any existing in the package that gets used) and then fail to update the web.xml in the Merge command. It shows the "The Web Service Name has been used in the web.xml of the web project." error dialog and stops in a bad state.

2) We can add a test prior to generating the classes to see if the package and class combo already exists and throw a status message up saying that they need to change the package name to get it working. 

3) But that leaves the Servlet name issue we hit in #1. The Servlet name is created as part of the Implementation Class generation step, and the user has no way of changing it. 

Lukas has spun off JBIDE-7913 to deal with the overwriting issue, but that leaves the other bits.

If we add a "Servlet Name" field on the "JBoss Web Service Code Generation Configuration" page (the WSDL2JavaCodeGenConfigWidget), we should be able to override the Servlet name in a similar way we do with the package name. That would provide a way for the user to supply a custom Servlet name and get around this problem. 

What do you think?

> Cannot create two or more top down web services in a web project
> ----------------------------------------------------------------
>
>                 Key: JBIDE-7681
>                 URL: https://issues.jboss.org/browse/JBIDE-7681
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Webservices
>    Affects Versions: 3.2.0.CR1
>            Reporter: Lukas Jungmann
>            Assignee: Brian Fitzpatrick
>            Priority: Critical
>             Fix For: 3.2.0.CR1
>
>         Attachments: JBIDE-7681.diff, WsdlWsAssemble.wsdl, WsdlWsDeploy.wsdl
>
>   Original Estimate: 0 minutes
>  Remaining Estimate: 0 minutes
>
> -create a new ear project ("Ear")
> -create a new dynamic web project ("WsWar")
> -create a top down ws from some wsdl using wtp wizard in WsWar project
>    - ws project WsWar, ear project Ear, server runtime JBossAS6.0, ws runtime JBossWS
> -create another top down ws from different wsdl there
>    - ws project WsWar, ear project Ear, server runtime JBossAS6.0, ws runtime JBossWS
> => wizard ends with "The Web Service Name has been used in the web.xml of the web project." error message and doesn't allow user to finish it but all I'm trying to do is to create two completely different services in one project
> message is comming from line 190 in org.jboss.tools.ws.creation.core.commands.MergeWebXMLCommand

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira