[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-7935) sanitzie xml unmarshalling code in DeltaCloudClient

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571813#comment-12571813 ] 

Andre Dietisheim commented on JBIDE-7935:
-----------------------------------------

I used JAXB on the Key and KeyAction (JBIDE-7763) domain objects. I was pretty disappointed by all changes I had to apply to my beans so that JAXB unmarshalls correctly. I therefore decided to use a classic approach instead. 

> sanitzie xml unmarshalling code in DeltaCloudClient
> ---------------------------------------------------
>
>                 Key: JBIDE-7935
>                 URL: https://issues.jboss.org/browse/JBIDE-7935
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: deltacloud
>    Affects Versions: 3.2.0.CR1
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>             Fix For: 3.2.x
>
>
> The code that unmarshals the XML responses from the deltacloud server is a mess. It is a mix of classic parsing and JAXB. Furthermore it has a lot of unsafe access (no null checks, no collection size checks etc.). It need serious refactoring.
> Talking of design the code should be separated from the client and grouped along the elements it unmarschals. This would allow us to switch communication to json or any other encoded form if needed. The current implementation would now allow that.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira