[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-7913) Top-Down ws wizard overwrites all java classes containing '@WebService(' string anywhere in the code

[Lukas Jungmann (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571929#comment-12571929 ] 

Lukas Jungmann commented on JBIDE-7913:
---------------------------------------

re note 1 - I'm sorry Grid but that's not true - wsconsume itself, when it is being run from command line, does not touch anything out side of scope of packages and sources it generates[*] and it is also not generating any implementation class. It is our tooling who is doing that and the tooling is wrongly assuming that 'default package == ""', it should assume that 'default package == toJavaPkg(/definitions[@targetNamespace])' (and the patch I attached to JBIDE-7681 is trying to fix just this assumption). As soon as the assumption will be fixed, ZwsImpl class won't be rewritten nor created (in case it would not exist)


[*]  if user does not pass target package to it (and there are really good real world reasons to not to do it), wsconsume simply calculates the package name from the value of 'targetNamespace' attribute in definitions element in WSDL. Although this attribute is optional per WSDL definition, WS-I Basic Profile makes it 'required' (and I assume that wsconsume requires it too), therefore it is unlikely that it won't be set in the WSDL.
(http://osdir.com/ml/web.services.general/2004-02/msg00014.html) 

> Top-Down ws wizard overwrites all java classes containing '@WebService(' string anywhere in the code
> ----------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-7913
>                 URL: https://issues.jboss.org/browse/JBIDE-7913
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Webservices
>    Affects Versions: 3.2.0.Beta2
>            Reporter: Lukas Jungmann
>            Assignee: Feng Qian
>            Priority: Blocker
>             Fix For: 3.2.0.CR1
>
>   Original Estimate: 0 minutes
>  Remaining Estimate: 0 minutes
>
> this came up as a result of JBIDE-7681 (see comment from 12/15/10)
> -create a new Dynamic web project
> -create following interface there:
> package x;
> import javax.jws.WebService;
> @WebService()
> public interface Zws {
>    String test();
> }
> -create following class there:
> package x;
> import javax.jws.WebService;
> @WebService()
> public class ZwsImpl {
>    public String test() {
>       return "Hello Dolly!";
>    }
> }
> -create some Top-Down ws there using default settings package (use default package)
> -open ZwsImpl.java in the editor
> =>
> Current: ZwsImpl class is rewritten
> Expected: the class remains untouched
> Note for myself: Check this also for Bottom up case

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira