[jbosstools-issues] [JBoss JIRA] Issue Comment Edited: (JBIDE-7864) Cloud View: launch instance is available on invalid cloud

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572058#comment-12572058 ] 

Andre Dietisheim edited comment on JBIDE-7864 at 12/22/10 4:12 PM:
-------------------------------------------------------------------

I implemented this by testing if the cloud the command is chosen on has any images.

This issue wants to disallow the user to launch an instance on a cloud-connection that is not valid, which we achieve with my current implementation.

The only case where we cannot rely on the images that are present in the client is where deltacloud does not report all images that are available on ec2. We then need to check the server for a given image-id. The client then has images, but does not have all of them. "Launch instance" is then availble and the aim is fullfilled.

The only case I see where this test may fail, is where an image gets added to the server after we defined the connection in the client. The image may then only show up upon refresh and "launch instance" may not be availble although we may be able to launch an instance out of this new image. IMHO offering "Launch instance" then may be misleading and not consistent for the user. 

I therefore believe that my test is absolutely sufficient.

      was (Author: adietish):
    I implemented this by testing if the cloud the command is chosen on has any images.

At first sight this might not be the proper solution since the wizard that allows you to launch an instance checks the server and the local cache for a given image. It may therefore fail if the cloud we want to launch an instance on is valid but has no images listed. Thinking about this twice I don't see any case where this might happen and might be of any relevance to the user. The only case where we need to check the server for a given image-id is where deltacloud does not report all images that are available on ec2. The client has images in this use case, but does not have all of them. I therefore believe that my test is absolutely sufficient.
  
> Cloud View: launch instance is available on invalid cloud
> ---------------------------------------------------------
>
>                 Key: JBIDE-7864
>                 URL: https://issues.jboss.org/browse/JBIDE-7864
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: deltacloud
>    Affects Versions: 3.2.0.Beta2
>            Reporter: Andre Dietisheim
>            Assignee: Max Andersen
>            Priority: Minor
>             Fix For: 3.2.0.CR1
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira