[jbosstools-issues] [JBoss JIRA] Resolved: (JBIDE-8011) Refactor participants throw exceptions if method name is short

Viacheslav Kabanovich (JIRA) jira-events at lists.jboss.org
Wed Dec 29 09:38:18 EST 2010 

     [ https://issues.jboss.org/browse/JBIDE-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Viacheslav Kabanovich resolved JBIDE-8011.
------------------------------------------

    Resolution: Done


> Refactor participants throw exceptions if method name is short
> --------------------------------------------------------------
>
>                 Key: JBIDE-8011
>                 URL: https://issues.jboss.org/browse/JBIDE-8011
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: common, JSF
>    Affects Versions: 3.2.0.Beta2
>            Reporter: Daniel Azarov
>            Assignee: Viacheslav Kabanovich
>            Priority: Critical
>             Fix For: 3.2.0.CR1
>
>
> 1. Create JSF KickStart project
> 2. Open User.java
> 3. create method public void get(){}
> 4.Right click on it then select Refactor->Rename
> 5. Type "pet" and press Enter
> FAIL:
> java.lang.reflect.InvocationTargetException
> at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:421)
> at org.eclipse.jface.window.ApplicationWindow$1.run(ApplicationWindow.java:759)
> at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
> at org.eclipse.jface.window.ApplicationWindow.run(ApplicationWindow.java:756)
> at org.eclipse.ui.internal.WorkbenchWindow.run(WorkbenchWindow.java:2600)
> at org.eclipse.ltk.ui.refactoring.RefactoringWizard.createChange(RefactoringWizard.java:599)
> at org.eclipse.ltk.ui.refactoring.RefactoringWizard.computeUserInputSuccessorPage(RefactoringWizard.java:438)
> at org.eclipse.ltk.ui.refactoring.RefactoringWizard.getStartingPage(RefactoringWizard.java:408)
> at org.eclipse.ltk.internal.ui.refactoring.RefactoringWizardDialog2.createContents(RefactoringWizardDialog2.java:612)
> at org.eclipse.jface.window.Window.create(Window.java:431)
> at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1089)
> at org.eclipse.ltk.ui.refactoring.RefactoringWizardOpenOperation$1.run(RefactoringWizardOpenOperation.java:171)
> at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
> at org.eclipse.ltk.ui.refactoring.RefactoringWizardOpenOperation.run(RefactoringWizardOpenOperation.java:192)
> at org.eclipse.ltk.ui.refactoring.RefactoringWizardOpenOperation.run(RefactoringWizardOpenOperation.java:115)
> at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate(RefactoringStarter.java:38)
> at org.eclipse.jdt.internal.ui.refactoring.UserInterfaceStarter.activate(UserInterfaceStarter.java:62)
> at org.eclipse.jdt.internal.ui.refactoring.reorg.RenameUserInterfaceStarter.activate(RenameUserInterfaceStarter.java:31)
> at org.eclipse.jdt.ui.refactoring.RenameSupport.openDialog(RenameSupport.java:159)
> at org.eclipse.jdt.internal.ui.refactoring.reorg.RenameLinkedMode.doRename(RenameLinkedMode.java:359)
> at org.eclipse.jdt.internal.ui.refactoring.reorg.RenameLinkedMode$EditorSynchronizer.left(RenameLinkedMode.java:119)
> at org.eclipse.jface.text.link.LinkedModeModel.exit(LinkedModeModel.java:341)
> at org.eclipse.jface.text.link.LinkedModeUI$4.run(LinkedModeUI.java:1194)
> at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
> at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
> at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3515)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3162)
> at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2629)
> at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2593)
> at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2427)
> at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:670)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:663)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1407)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1383)
> Caused by: java.lang.StringIndexOutOfBoundsException: String index out of range: 4
> at java.lang.String.substring(String.java:1934)
> at org.jboss.tools.jsf.model.handlers.bean.JSFRenameFieldParticipant.createChange(JSFRenameFieldParticipant.java:85)
> at org.eclipse.ltk.core.refactoring.participants.ProcessorBasedRefactoring.createChange(ProcessorBasedRefactoring.java:308)
> at org.eclipse.ltk.core.refactoring.CreateChangeOperation.run(CreateChangeOperation.java:124)
> at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:1975)
> at org.eclipse.ltk.internal.ui.refactoring.WorkbenchRunnableAdapter.run(WorkbenchRunnableAdapter.java:87)
> at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)
> Root exception:
> java.lang.StringIndexOutOfBoundsException: String index out of range: 4
> at java.lang.String.substring(String.java:1934)
> at org.jboss.tools.jsf.model.handlers.bean.JSFRenameFieldParticipant.createChange(JSFRenameFieldParticipant.java:85)
> at org.eclipse.ltk.core.refactoring.participants.ProcessorBasedRefactoring.createChange(ProcessorBasedRefactoring.java:308)
> at org.eclipse.ltk.core.refactoring.CreateChangeOperation.run(CreateChangeOperation.java:124)
> at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:1975)
> at org.eclipse.ltk.internal.ui.refactoring.WorkbenchRunnableAdapter.run(WorkbenchRunnableAdapter.java:87)
> at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)
> 1. Create JSF KickStart project
> 2. Open User.java
> 3. create method public void getU(){}
> 4.Right click on it then select Refactor->Rename
> 5. Type "aaa" and press Enter
> FAIL:
> java.lang.StringIndexOutOfBoundsException: String index out of range: 0
> at java.lang.StringBuffer.charAt(StringBuffer.java:162)
> at org.jboss.tools.jst.web.kb.refactoring.RefactorSearcher.getPropertyName(RefactorSearcher.java:414)
> at org.jboss.tools.jsf.ui.el.refactoring.RenameMethodParticipant.initialize(RenameMethodParticipant.java:115)
> at org.eclipse.ltk.core.refactoring.participants.RefactoringParticipant.initialize(RefactoringParticipant.java:105)
> at org.eclipse.ltk.core.refactoring.participants.ParticipantExtensionPoint.getParticipants(ParticipantExtensionPoint.java:100)
> at org.eclipse.ltk.core.refactoring.participants.ParticipantManager.loadRenameParticipants(ParticipantManager.java:74)
> at org.eclipse.jdt.internal.corext.refactoring.rename.RenameModifications.loadParticipants(RenameModifications.java:190)
> at org.eclipse.jdt.internal.corext.refactoring.rename.JavaRenameProcessor.loadParticipants(JavaRenameProcessor.java:40)
> at org.eclipse.ltk.core.refactoring.participants.ProcessorBasedRefactoring.checkFinalConditions(ProcessorBasedRefactoring.java:233)
> at org.eclipse.ltk.core.refactoring.CheckConditionsOperation.run(CheckConditionsOperation.java:85)
> at org.eclipse.ltk.core.refactoring.CreateChangeOperation.run(CreateChangeOperation.java:121)
> at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:1975)
> at org.eclipse.ltk.internal.ui.refactoring.WorkbenchRunnableAdapter.run(WorkbenchRunnableAdapter.java:87)
> at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)
> 1. Create JSF KickStart project
> 2. Open User.java
> 3. create method public void is(){}
> 4.Right click on it then select Refactor->Rename
> 5. Type "i123" and press Enter
> FAIL:
> java.lang.StringIndexOutOfBoundsException: String index out of range: 0
> 	at java.lang.StringBuffer.charAt(StringBuffer.java:162)
> 	at org.jboss.tools.common.el.core.resolver.TypeInfoCollector.getPropertyPresentations(TypeInfoCollector.java:1210)
> 	at org.jboss.tools.common.el.core.ca.AbstractELCompletionEngine.resolveLastSegment(AbstractELCompletionEngine.java:827)
> 	at org.jboss.tools.common.el.core.ca.AbstractELCompletionEngine.resolveELOperand(AbstractELCompletionEngine.java:594)
> 	at org.jboss.tools.common.el.core.ca.AbstractELCompletionEngine.resolveELOperand(AbstractELCompletionEngine.java:257)
> 	at org.jboss.tools.common.el.core.ca.AbstractELCompletionEngine.resolve(AbstractELCompletionEngine.java:135)
> 	at org.jboss.tools.jsf.web.validation.ELValidator.validateElOperand(ELValidator.java:352)
> 	at org.jboss.tools.jsf.web.validation.ELValidator.validateELExpression(ELValidator.java:319)
> 	at org.jboss.tools.jsf.web.validation.ELValidator.validateEL(ELValidator.java:310)
> 	at org.jboss.tools.jsf.web.validation.ELValidator.validateFile(ELValidator.java:299)
> 	at org.jboss.tools.jsf.web.validation.ELValidator.validate(ELValidator.java:170)
> 	at org.jboss.tools.jst.web.kb.internal.validation.ValidatorManager.validate(ValidatorManager.java:112)
> 	at org.jboss.tools.jst.web.kb.internal.validation.ValidatorManager.validateInJob(ValidatorManager.java:83)
> 	at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78)
> 	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

More information about the jbosstools-issues mailing list