[jbosstools-issues] [JBoss JIRA] Updated: (JBIDE-5916) Wrong Compiler Compliance Level set when creating new ESB Project

[Max Rydahl Andersen (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBIDE-5916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Max Rydahl Andersen updated JBIDE-5916:
---------------------------------------

    Assignee: Viacheslav Kabanovich  (was: Max Rydahl Andersen)


Ok, so there are two issues here, one easy to fix, and one a bit trickier.

1) We should not add @Override by default to the implementation because
@Override is only possibly to put on interface method in Java 6, not Java 5.

Slava, could please attach a patch that will remove the @Override annotation for the action and assign back to me ?

For those who care here are the links that convinced me of the above:
Java 6 @Override snafu:
http://dertompson.com/2008/01/25/override-specification-changes-in-java-6/
http://blogs.sun.com/ahe/entry/override_snafu

ESB API doc showing what is interface and what is class:
http://www.jboss.org/file-access/default/members/jbossesb/freezone/docs/4.2MR2/javadoc/esb/org/jboss/soa/esb/actions/AbstractActionPipelineProcessor.html
http://www.jboss.org/file-access/default/members/jbossesb/freezone/docs/4.2MR2/javadoc/esb/org/jboss/soa/esb/actions/ActionPipelineProcessor.html#process%28org.jboss.soa.esb.message.Message%29

2) The ESB project wizard seems to hardcode the default Facet configuration for EAP and does not provide any way
to modify the configured setup (look at dynamic web project or Seam project here is a combo and modify button to let user configure the facets used during project creation)

Since EAP 5 doesn't exist in a Java 5 version (we should check that ?) the default for facet configuration of EAP (and by consequence also SOA-P) should thus be Java 6.




 


> Wrong Compiler Compliance  Level set when creating new ESB Project
> ------------------------------------------------------------------
>
>                 Key: JBIDE-5916
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-5916
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: esb
>    Affects Versions: 3.1.0.CR3
>         Environment: JBDS 3.0.0v201002190339M-H173-CR2
> Java Sun JDK 1.6.0_16-b01
> JBoss [SOA] 5.0.0.GA_SOA (build: SVNTag=5.0.0.GA_SOA date=201002151345)
>            Reporter: Vlado Pakan
>            Assignee: Viacheslav Kabanovich
>             Fix For: 3.1.0.CR3, 3.1.1
>
>
> When new ESB Project is created (File > New > Others > ESB Project) this project has set Compiler Compliance Level to 1.5 (Project > Properties > Java Compiler) even when only Java JDK 1.6 Runtime is specified within workspace.
> Then when user adds new ESB Action to this project (File > New > Others > ESB Action) it generates new class with this content (JBoss ESB Runtime jas to be added to project classpath):
> import org.jboss.soa.esb.actions.AbstractActionPipelineProcessor;
> import org.jboss.soa.esb.helpers.ConfigTree;
> import org.jboss.soa.esb.actions.ActionProcessingException;
> import org.jboss.soa.esb.message.Message;
> public class EsbAction extends AbstractActionPipelineProcessor {
> 	protected ConfigTree _config;
> 	public EsbAction(ConfigTree config) {
> 		_config = config;
> 	}
> 	@Override
> 	public Message process(Message message) throws ActionProcessingException {
> 		//ADD CUSTOM ACTION CODE HERE
> 		return message;
> 	}
> }
> And compiler is complaining about @Override annotation on method process(Message) displaying this error:
> The method process(Message) of type EsbAction must override a superclass method
> Either when Compiler Compliance level is set to 1.6 or Project Facets Java version is set to 6.0 (Project Properties > Project Facets > Java) error disappear.
> I think it should work in the way that when user creates new EBS Action it should be created without errors so Compiler Compliance Level or Project Facets Java should be set properly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira