[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-5920) OpenOn does not work for ui:composition template attribute

[Viacheslav Kabanovich (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-5920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12516567#action_12516567 ] 

Viacheslav Kabanovich commented on JBIDE-5920:
----------------------------------------------

I think the patch proposed does not solve the problem correctly. Web descriptor for the project defines two url-patterns, *.jsf and /faces/*.
In this case JSFUrlPattern created by PatternLoader is CompoundPattern that contains both PostfixUrlPattern (for *.jsf) and PrefixUrlPattern (for /faces/). 
So, method getJSFPaths(String url) should be implemented in CompoundPattern by collecting results returned by this method on member patterns.

CompoundPattern:
	public List<String> getJSFPaths(String url) {
		List<String> result = new ArrayList<String>();
		for (JSFUrlPattern pattern: patterns) {
			result.addAll(pattern.getJSFPaths(url));
		}
		return result;
	}

As to PrefixUrlPattern, its getJSFPaths method, of course, should be implemented, however, not by adding variable url as is, but by making use of getJSFPath method:

PrefixUrlPattern:
	public List<String> getJSFPaths(String url) {
		List<String> result = new ArrayList<String>();
		String path = getJSFPath(url);
		if(path != null && path.length() > 0) result.add(path);
		return result;
	}




> OpenOn does not work for ui:composition template attribute
> ----------------------------------------------------------
>
>                 Key: JBIDE-5920
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-5920
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: jsp/jsf/xml source editing
>    Affects Versions: 3.1.0.CR2
>            Reporter: Maxim Areshkau
>            Assignee: Viacheslav Kabanovich
>             Fix For: 3.1.1, 3.2.next
>
>         Attachments: Patch.patch
>
>
> #1 import http://download.jboss.com/jboss-richfaces/richfaces-demo-4.0.0.ALPHA1-tomcat6.war project into workspace
> #2 open page welcome.xhtml
> #3 try open on template <ui:composition template="/templates/main.xhtml">
> ASSERT IT should work, but doesn't

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira