[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-5617) Hide nodes not working in all cases

[Tom Fennelly (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-5617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12503276#action_12503276 ] 

Tom Fennelly commented on JBIDE-5617:
-------------------------------------

I'm not really sure what your issue is from your description.

I had a look at how you're using the templating API and you're not using it as it was intended.  Perhaps I wasn't clear enough about this in the docs.

You seem to be creating a new Template Builder instance with every add/remove of a mapping.  The intention always was that the editor would maintain a single instance of the TemplateBuilder (per template), adding and removing mappings from it as the user adds and removes mappings.  On this single instance, you can call TemplateBuilder.buildTemplate() as many times as you like i.e. for every mapping added/removed. 

This might be OK, but I'm not sure since it is not how the templating API was designed to be used.  Is there any way we can change to use it as intended?  I find it hard to see how you are doing it currently without duplicating some of the behavior of the templating API, recording the current set of mappings etc so you can do your "replay all mappings" for every add/remove mappings (as you are currently doing, as it seems to me).  In order to do the replay, you must have a record of all the mappings, right?  You shouldn't need to be doing this replay and since it was not as it was intended to be used, I'm not sure of side effects etc.  If you can't redo the editor parts, then I will look more closely and try to get the tests in the templating API to better match how you are using it.  That way we'll have a better idea of what the possible side effects are.

> Hide nodes not working in all cases
> -----------------------------------
>
>                 Key: JBIDE-5617
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-5617
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: smooks
>            Reporter: Tom Fennelly
>            Assignee: Xue Peng
>             Fix For: 3.1.0.CR2
>
>
> In some situations, not all of the "hide" nodes being returned in the Mapping instance (Templating API) are actually being hidden.
> See the following screencast... http://www.screencast.com/t/NWIwNDNhN

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira