[jbosstools-issues] [JBoss JIRA] Resolved: (JBIDE-5713) Incoherent module assembly structure

[Rob Stryker (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBIDE-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Stryker resolved JBIDE-5713.
--------------------------------

    Resolution: Done


Ok... so to clarify, what you *should* see on the module assembly page for each of the ejbs is, essentially, NOTHING.  Nada. You shouldn't see a damn thing ;)  Except for the root folder (EarContent) mapping.    Why? Because in "Module Assembly", all you're doing is telling it how to put the stuff together. Pretty simple.

The 2 lib jars are sitting in the Ear project, not inside the ejb jars, so the ejb jars have no need to "assemble" the libs. 

Anyway, it turns out the problem is that J2EEVirtualComponent.getReferences() is returning all sorts of made up references, not just the hard-coded references from the xml file. So I've done a little API addition to allow for module types to filter down to just their hard-coded references. 

Should work better now.  

I'm pretty sure I'll need to make slightly different changes upstream, but this should be ok. 

> Incoherent module assembly structure
> ------------------------------------
>
>                 Key: JBIDE-5713
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-5713
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>    Affects Versions: 3.1.0.CR1
>         Environment: Vista, JBT 3.1.CR1
>            Reporter: Fred Bricon
>            Assignee: Rob Stryker
>            Priority: Critical
>             Fix For: 3.1.0.CR2
>
>         Attachments: incoherent_module_assembly_structure.jpg, incoherentModulAssemblyProjects.zip
>
>
> I was a bit puzzled -and kinda worried- after opening the module assembly page of an EJB project.
> As you can see on the following screenshot (incoherent_module_assembly_structure.jpg), the page indicates EJB dependencies of my testEJB2 project should be exported in the resulting jar. Fortunately, they aren't (hence the minor priority), but it's pretty disturbing.
> My understanding of the module assembly page is that :
> - it's just a GUI over ./settings/org.eclipse.wst.common.component
> - it should reflect the content of the produced assembly. i.e everything in this page should be present in the resulting .jar/.ear/.sar,  whatever.
> well, it's also probable I misunderstood a lot :-)
> regards,
> Fred Bricon

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira