[jbosstools-issues] [JBoss JIRA] Resolved: (JBIDE-6596) New Seam WAR project has incorrect deployment artifact structure

[Denis Golovin (JIRA)]

     [ https://jira.jboss.org/browse/JBIDE-6596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Denis Golovin resolved JBIDE-6596.
----------------------------------

    Resolution: Done


Patch below has been applied to trunk and M1 branch. Both EAR and WAR seam projects works out of the box now.
Index: jbosscore/org/jboss/ide/eclipse/as/core/publishers/JstPublisher.java
===================================================================
--- jbosscore/org/jboss/ide/eclipse/as/core/publishers/JstPublisher.java	(revision 23424)
+++ jbosscore/org/jboss/ide/eclipse/as/core/publishers/JstPublisher.java	(working copy)
@@ -117,12 +117,12 @@
 		if( !(new Path(module.getName()).segmentCount() > 1 ) && delete)
 			list.addAll(Arrays.asList(localSafeDelete(deployPath)));
 
-		if( !deployPackaged(moduleTree) && !isBinaryObject(moduleTree)) {
+		if( !deployPackaged(moduleTree) && !j2eeModule.isBinary()) {
 			LocalCopyCallback handler = new LocalCopyCallback(server.getServer(), deployPath, tempDeployPath);
 			PublishCopyUtil util = new PublishCopyUtil(handler);
 			list.addAll(Arrays.asList(util.publishFull(members, monitor)));
 		}
-		else if( isBinaryObject(moduleTree))
+		else if(j2eeModule.isBinary())
 			list.addAll(Arrays.asList(copyBinaryModule(moduleTree)));
 		else
 			list.addAll(Arrays.asList(packModuleIntoJar(moduleTree[moduleTree.length-1], deployPath)));
@@ -152,12 +152,13 @@
 		IStatus[] results = new IStatus[] {};
 		IPath deployPath = getDeployPath(moduleTree, server);
 		IPath tempDeployPath = getTempDeployFolder(moduleTree, server);
+		IJ2EEModule j2eeModule = (IJ2EEModule) module.loadAdapter(IJ2EEModule.class, null);		
 		LocalCopyCallback handler = null;
-		if( !deployPackaged(moduleTree) && !isBinaryObject(moduleTree)) {
+		if( !deployPackaged(moduleTree) && !j2eeModule.isBinary()) {
 			handler = new LocalCopyCallback(server.getServer(), deployPath, tempDeployPath);
 			results = new PublishCopyUtil(handler).publishDelta(delta, monitor);
 		} else if( delta.length > 0 ) {
-			if( isBinaryObject(moduleTree))
+			if( j2eeModule.isBinary())
 				results = copyBinaryModule(moduleTree);
 			else
 				results = packModuleIntoJar(moduleTree[moduleTree.length-1], deployPath);
Index: jbosscore/org/jboss/ide/eclipse/as/core/publishers/PublishUtil.java
===================================================================
--- jbosscore/org/jboss/ide/eclipse/as/core/publishers/PublishUtil.java	(revision 23424)
+++ jbosscore/org/jboss/ide/eclipse/as/core/publishers/PublishUtil.java	(working copy)
@@ -129,9 +129,6 @@
 		String type, modName, name, uri, suffixedName;
 		for( int i = 0; i < moduleTree.length; i++ ) {	
 			IJ2EEModule j2eeModule = (IJ2EEModule) moduleTree[i].loadAdapter(IJ2EEModule.class, null);
-			if (j2eeModule != null && j2eeModule.isBinary()) {
-				continue;
-			}
 			type = moduleTree[i].getModuleType().getId();
 			modName = moduleTree[i].getName();
 			name = new Path(modName).lastSegment();


> New Seam WAR project has incorrect deployment artifact structure
> ----------------------------------------------------------------
>
>                 Key: JBIDE-6596
>                 URL: https://jira.jboss.org/browse/JBIDE-6596
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Seam
>    Affects Versions: 3.2.0.M1
>         Environment: JBT 3.2.0.M1 
> EAP 5.0, EAP 5.1.CR1
>            Reporter: Dominik Pospisil
>            Assignee: Denis Golovin
>            Priority: Blocker
>             Fix For: 3.2.0.M1, 3.2.0.M2, 3.2.x
>
>
> New Seam Project wizard creates project with incorrect structure, deployment of the project fails.
> The deployed artifact contains:
> /WEB-INF/lib/jboss-seam.jar/jboss-seam.jar
> instead of:
> /WEB-INF/lib/jboss-seam.jar
> Steps to reproduce:
> 1) Register and start EAP 5.0 runtime
> 2) File -> New -> Seam Web project, choose EAP 5.0 runtime and EAP 5.0 Seam, WAR packaging option
> 3) Wait until project gets deployed

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira