[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name

[Max Rydahl Andersen (JIRA)]

    [ https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12533892#action_12533892 ] 

Max Rydahl Andersen commented on JBIDE-6396:
--------------------------------------------

Michael, doesn't this patch breaks down if catalog or schema has .'s in them ?

btw. Fixing qualifier method wouldn't be the right solution since that is qualifier in the java package sense used many other places where its correct.

should be relaying the qualifiication to the metadatadialect I guess.

...and shouldn't these things be quoted to be deterministic ? (trying to understand how MetaMatrix detects this properly)


> Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-6396
>                 URL: https://jira.jboss.org/browse/JBIDE-6396
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: Hibernate
>    Affects Versions: 3.1.0.GA
>            Reporter: Michael Walker
>            Assignee: Max Rydahl Andersen
>         Attachments: JBIDE-tablename-with-dots-patch-mpw.txt
>
>
> The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog and schema name for each table, given the fully-qualified name.
> StringHelper.qualifier() assumes that everything proceeding the final "." in the fully-qualified name represents the qualifier. 
> This assumption breaks down if a table contains a dot in the name. This is found to be the case when working with MetaMatrix (and possibly Teiid). 
> The result is that the Filter Wizard will generate invalid filters, based on the incorrect naming of catalog and schema for each table.
> As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt tools and verified that this fixed the problem when working with MetaMatrix.
> This may be better addressed by changing the behavior of StringHelper.qualifier() itself. 
> See forum discussion for details.
> Patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira