[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-6476) [Smooks] Several class loader related unsafe places in JBoss Tools

[Max Rydahl Andersen (JIRA)]

    [ https://jira.jboss.org/browse/JBIDE-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12536177#action_12536177 ] 

Max Rydahl Andersen commented on JBIDE-6476:
--------------------------------------------

the point Vitali leaves out is that use of current thread context classloader should be done so the original classloader gets returned within proper try and catch - but since this code is commented out I don't really see why this issue is here ?

Tom, feel free to close if those code lines are simply never gonna be used.

> [Smooks] Several class loader related unsafe places in JBoss Tools
> ------------------------------------------------------------------
>
>                 Key: JBIDE-6476
>                 URL: https://jira.jboss.org/browse/JBIDE-6476
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: smooks
>    Affects Versions: 3.1.x, 3.2.x
>            Reporter: Brian Fitzpatrick
>            Assignee: Tom Fennelly
>             Fix For: 3.1.x, 3.2.x
>
>   Original Estimate: 0 minutes
>  Remaining Estimate: 0 minutes
>
> This originally came from JBIDE-6466
> I find several unsafe places which are related with Thread.currentThread().getContextClassLoader() and Thread.currentThread().setContextClassLoader(). These places in code could have dramatic outcome during JBoss Tools normal work.
> 6) \jbosstools\trunk\smooks\plugins\org.jboss.tools.smooks.ui\src\org\jboss\tools\smooks\edimap\editor\EDIMapFormPage.java 
> - here is potential unsafe code commented;

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira