[jbosstools-issues] [JBoss JIRA] Commented: (JBDS-1091) Installer does not always import all found App servers to newly created workspace

[Snjezana Peco (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBDS-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12520024#action_12520024 ] 

Snjezana Peco commented on JBDS-1091:
-------------------------------------

There is a problem with the org.jboss.tools.jbpm.common plugin. Namely, within JBIDE-5951 the visibility of the INSTANCE field is changed from public to private which is the reason why the jBPM runtimes aren't initialized correctly in JBDS 3.0.0.GA (the runtime plugin uses the INSTANCE field; the getInstance() method introduced by this change) . If I change the runtime plugin, it won't be compatible with older versions.

The following is part of the patch attached to JBIDE-5951 that changes API.

...
-	public static final PreferencesManager INSTANCE = new PreferencesManager();
+	private static PreferencesManager INSTANCE;
 	
-	private PreferencesManager() {
+	public static PreferencesManager getInstance() {
+		if (INSTANCE == null) {
+			INSTANCE = new PreferencesManager();
+		}
+		return INSTANCE;
+	}
+	
...

The fix for JBDS-1091 is simple. It adds a dependency on the org.eclipse.wst.server.ui plugin, but that is minor because the runtime plugin already depends on the org.eclipse.wst.server.core plugin. However, the fix can't be committed until JBID-5951 is fixed.

Max,
I can fix both of the bugs if you agree.

> Installer does not always import all found App servers to newly created workspace
> ---------------------------------------------------------------------------------
>
>                 Key: JBDS-1091
>                 URL: https://jira.jboss.org/jira/browse/JBDS-1091
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Bug
>          Components: installer
>    Affects Versions: 3.0.0.CR2
>         Environment: Fedora 12, x86_64
>            Reporter: Libor Zoubek
>            Assignee: Snjezana Peco
>             Fix For: 3.0.1.GA, 3.1.0.beta1
>
>         Attachments: application_platforms.properties, org.jboss.tools.runtime.zip
>
>
> Is seem that installer has problem with finding servers. It finds it during installation process, but when I then  run JBDS with new workspace, I can't see servers found during installation in Server View. There are quite strange conditions to make this happen. 
> Requirements:
>  * JBDS CR2
>  * jboss-eap-noauth-5.0.0.GA.zip
> unzip jboss-eap-noauth-5.0.0.GA.zip  /tmp/
> cp -a /tmp/jboss-eap-5.0/jboss-as /tmp
> Now we have EAP5 plattform in /tmp/jboss-eap-5.0/ and jboss 5 AS in /tmp/jboss-as
> Steps to reproduce: 
> * Run JBDS CR2 installer
> * When adding servers, the order DOES matter (If you find servers in reverse order, everything works as expected)
>   * Find -> Select path /tmp/jboss-as
>   * Find -> Select path tmp/jboss-eap-5.0/
> After installation run JBDS and point workspace to some new/empty dir
> Result : No servers or only one of them (always eap) can be found in Server View.
> The installer behaviour is really strange. I've tried it almost 30times ( delete installation and workspace, than install again) at this issue does not happen every time.
> Secondly, I've figured out, that installer is probably creating Server configurations in the latest step of installation (when it creates shortcuts). One can leave installation process at this step (I do not need to have shortcut on my desktop, so I quit installation), then absolutely no app server configurations appear in JBDS afterwards.  Can we move this step to some earlier phase of installation? 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira