[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-6186) Mapping diagram couldn't save state if uses inner classes

[Dmitry Geraskov (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12529540#action_12529540 ] 

Dmitry Geraskov commented on JBIDE-6186:
----------------------------------------

Shapes use getKey() method to get unigue key and save themselves into the file with the key.
When they need to retrieve the state they use the same method to retrieve the properties from the file. So the key doen't impact on the visual names.

> Mapping diagram couldn't save state if uses inner classes
> ---------------------------------------------------------
>
>                 Key: JBIDE-6186
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-6186
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Hibernate
>    Affects Versions: 3.1.0.GA
>            Reporter: Dmitry Geraskov
>            Assignee: Dmitry Geraskov
>            Priority: Critical
>             Fix For: 3.1.x, 3.2.next
>
>         Attachments: JBIDE-6186_patch.txt, JBIDE-6186_patch_full.txt, JBIDE-6186_patch_full2.txt
>
>
> To reproduce create Entity with inner class Id (or use caveat emptor example CategorizedItem$Id).
> We need to replace $ in class name before saving it into memento (replace to '.' I guess).
> org.w3c.dom.DOMException: INVALID_CHARACTER_ERR: An invalid or illegal XML character is specified. 
> 	at com.sun.org.apache.xerces.internal.dom.CoreDocumentImpl.createAttribute(Unknown Source)
> 	at com.sun.org.apache.xerces.internal.dom.ElementImpl.setAttribute(Unknown Source)
> 	at org.eclipse.ui.XMLMemento.putString(XMLMemento.java:431)
> 	at org.jboss.tools.hibernate.ui.diagram.editors.model.OrmShape.setPoint(OrmShape.java:366)
> 	at org.jboss.tools.hibernate.ui.diagram.editors.model.OrmShape.setPosition(OrmShape.java:395)
> 	at org.jboss.tools.hibernate.ui.diagram.editors.model.OrmShape.saveState(OrmShape.java:427)
> 	at org.jboss.tools.hibernate.ui.diagram.editors.model.BaseElement.saveState(BaseElement.java:373)
> 	at org.jboss.tools.hibernate.ui.diagram.editors.model.OrmDiagram.saveState(OrmDiagram.java:602)
> 	at org.jboss.tools.hibernate.ui.view.DiagramEditorInput.saveState(DiagramEditorInput.java:133)
> 	at org.eclipse.ui.internal.EditorHistoryItem.saveState(EditorHistoryItem.java:222)
> 	at org.eclipse.ui.internal.EditorHistory.saveState(EditorHistory.java:152)
> 	at org.eclipse.ui.internal.Workbench.saveState(Workbench.java:2446)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira