[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-7484) DeltaCloudClient: remove instance methods (#startInstance, #stopInstance, etc.) in order to remove code duplication

[Andre Dietisheim (JIRA)]

    [ https://jira.jboss.org/browse/JBIDE-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561183#action_12561183 ] 

Andre Dietisheim commented on JBIDE-7484:
-----------------------------------------

I now switched to actions that store the URL where they might be reached. adapted the tests. I will now remove the instance methods in the next step.

> DeltaCloudClient: remove instance methods (#startInstance, #stopInstance, etc.) in order to remove code duplication
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-7484
>                 URL: https://jira.jboss.org/browse/JBIDE-7484
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>
> The DeltaCloudClient currently has duplicate implementations of instance related functionalities (start, stop, destroy, reboot). I'll remove the deprecated methods:
> Mail with Jeff Johnson on the 29th of Oct:
> >> I discovered another possible duplication:
> >>
> >> DeltaCloudClient#performInstanceAction allows you to perfom START, STOP,
> >> REBOOT, DESTROY (Instance#Action)
> >>
> >> On the other hand most of these actions also have their own method in
> >> DeltaCloudClient:
> >>
> >> startInstance
> >> shutdownInstance (=STOP)
> >> rebootInstance
> >> destroyInstance
> >>
> >> Is there any reason for this duplication? Which one would you remove
> >> (the performaAction or the individual methods)?
> >>
> >> Thanks!
> >> André
> >I would remove the individual methods.  Remember that I copied and hacked an ancient version of this code so some methods that Martin thought 
> > might be useful were never used.  I didn't go about pruning them.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira