[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-7500) ESB Editor 1.3 generates incomplete template when creating New->Custom Action.

[Viacheslav Kabanovich (JIRA)]

    [ https://jira.jboss.org/browse/JBIDE-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561863#action_12561863 ] 

Viacheslav Kabanovich commented on JBIDE-7500:
----------------------------------------------

New ESB Action dialog has options
- As AbstractActionPipelineProcessor implementation
- As annotated POJO
By default, POJO is selected and no special constructor is generated. Customer should select the other option rather than browse for AbstractActionPipelineProcessor.

I have found 2 issues: 
1) For version 1.3, org.jboss.soa.esb.actions.AbstractActionPipelineProcessor is not auto-inserted into 'Superclass' field when 'As AbstractActionPipelineProcessor implementation' is selected. - fixed.
2) If a superclass having an abstract method process() is selected for a POJO case, generation fails. - fixed.

Brian, Ken, can we close this issue with these fixes and explanation, or is it reasonable to ignore option 'As annotated POJO' when customer manualy selected superclass org.jboss.soa.esb.actions.AbstractActionPipelineProcessor?

> ESB Editor 1.3 generates incomplete template when creating New->Custom Action.
> ------------------------------------------------------------------------------
>
>                 Key: JBIDE-7500
>                 URL: https://jira.jboss.org/browse/JBIDE-7500
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: esb
>    Affects Versions: 3.2.0.Beta1
>         Environment: JBDS 4 Beta 1.  RHEL 6, x86_64.  Sun 1.6 JDK 64-bit.
>            Reporter: Ken Johnson
>            Assignee: Viacheslav Kabanovich
>             Fix For: 3.2.0.Beta2
>
>
> Using the ESB Editor: after creating a new Service, I create a new custom action by right-selecting the Action folder under the newly created service and choose New-> Custom Action...  
> I enter MyAction for both Name and Class and click OK.
> Click the Class link under the Action section in the editor panel to bring up New ESB Action dialog.
> Enter Package name as org.jboss.foo
> Browse for Superclass and choose AbstractActionPipelineProcessor
> Everything else left as default.
> Click Finish.
> The following is generated for the constructor:
> 	public MyAction() {
> 		// TODO Auto-generated constructor stub
> 	}
> This is an invalid constructor at deployment time.  The correct constructor should accept ConfigTree, a local variable should be generated for the config info and org.jboss.soa.esb.helpers.ConfigTree should be added to the imports.  It appears prior versions of the tooling worked this way.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira