[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-7532) Fix hibernate tools junit tests

[Max Andersen (JIRA)]

    [ https://jira.jboss.org/browse/JBIDE-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562940#action_12562940 ] 

Max Andersen commented on JBIDE-7532:
-------------------------------------

Great patch and description Dmitry! thanks!

Here are my comments:
Not competely grokking why you prefer to run the delete of testdb in a never ending loop ?

good catch about #2 ..the code is though less clean now but I understand the reasoning and its cool for now. (i.e. might make sense to isolate the tests that need specific cleanup into a separate test class so it could just be done via setup/teardown.

#5  insert table replaced with insert into and ' replaced with "...hmm - did hsqldb change its syntax ?

#3 JPABogusPUnit were spitting out errors about hibernatetool task not being able to load.
Was fixed by uncommenting the hibernatetool task loading. Now it runs in both maven and eclipse launch of the tests.
I also updated this test's assert to actually look for the right error condition and not just any exception.

With those fixed i'm still left with the following:
Failed tests: 
  testParentComponentFailureExpected(org.hibernate.tool.hbm2x.Hbm2JavaTest)
  testAutoIncrement(org.hibernate.tool.test.jdbc2cfg.identity.H2IdentityTest)
  testAutoIncrement(org.hibernate.tool.test.jdbc2cfg.identity.MySQLIdentityTest)
  testMultiColumnForeignKeys(org.hibernate.tool.test.jdbc2cfg.OracleCompositeIdOrderTest)
  testViewAndSynonyms(org.hibernate.tool.test.jdbc2cfg.OracleViewsTest)

Tests in error: 
  testGeneration(org.hibernate.tool.test.jdbc2cfg.TernarySchemaTest)
  testTernaryModel(org.hibernate.tool.test.jdbc2cfg.TernarySchemaTest)
  testExporter(org.hibernate.tool.hbm2x.DocExporterTest)
  testCommentIncluded(org.hibernate.tool.hbm2x.DocExporterTest)
  testGenericsRenderedCorrectly(org.hibernate.tool.hbm2x.DocExporterTest)
  testInheritedProperties(org.hibernate.tool.hbm2x.DocExporterTest)

The failed tests are expected because of dialect diff.

and tests in error TernarySchemaTest fails because of hsqldb 2 dependency and docexporter because of not dot (graphviz) in path.

We need to eventually fix these so they will actually run properly - but for now this is similar to what we had before.

I've committed the patch + my few changes described above.

> Fix hibernate tools junit tests
> -------------------------------
>
>                 Key: JBIDE-7532
>                 URL: https://jira.jboss.org/browse/JBIDE-7532
>             Project: Tools (JBoss Tools)
>          Issue Type: Task
>          Components: Hibernate
>    Affects Versions: 3.2.0.Beta1
>            Reporter: Dmitry Geraskov
>            Assignee: Max Andersen
>            Priority: Critical
>             Fix For: 3.2.0.Beta2
>
>         Attachments: tests.patch.txt
>
>
> There are some tests failing in hibernate-tools core.
> They fails from time to time on my machine.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira