[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-7532) Fix hibernate tools junit tests

[Dmitry Geraskov (JIRA)]

    [ https://jira.jboss.org/browse/JBIDE-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563315#comment-12563315 ] 

Dmitry Geraskov commented on JBIDE-7532:
----------------------------------------

>good catch about #2 ..the code is though less clean now but I understand the reasoning and its cool for now. (i.e. might make sense to isolate the tests that need specific cleanup into a separate test class so it could just be done via setup/teardown. 
The blocked file is "...\testdb\hsqldb.log" it is blocked some time and then released. I thought about Thread#sleep() and limitation of the number of attempts but didn't implement it.

>#5 insert table replaced with insert into and ' replaced with "...hmm - did hsqldb change its syntax ? 
I don't think "insert table" ever worked in hsqldb.
Anyway we should use standard sql syntax as our tests are not just for hsqldb. I

> Fix hibernate tools junit tests
> -------------------------------
>
>                 Key: JBIDE-7532
>                 URL: https://jira.jboss.org/browse/JBIDE-7532
>             Project: Tools (JBoss Tools)
>          Issue Type: Task
>          Components: Hibernate
>    Affects Versions: 3.2.0.Beta1
>            Reporter: Dmitry Geraskov
>            Assignee: Max Andersen
>            Priority: Critical
>             Fix For: 3.2.0.Beta2
>
>         Attachments: tests.patch.txt
>
>
> There are some tests failing in hibernate-tools core.
> They fails from time to time on my machine.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira