[jbosstools-issues] [JBoss JIRA] Updated: (JBIDE-7517) Problem with deployment when Eclipse and JBoss AS are installed on different Windows drives

[Rob Stryker (JIRA)]

     [ https://jira.jboss.org/browse/JBIDE-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Stryker updated JBIDE-7517:
-------------------------------

    Assignee: Snjezana Peco  (was: Rob Stryker)


I am not able to fix this bug or even properly debug it in my current work environment. Snjezana, could you help? 

The places to look are in AbstractServerToolsPublisher.java in the method protected IPath getDeployPath(IModule[] moduleTree, IDeployableServer server).

The method looks as follows:
	protected IPath getDeployPath(IModule[] moduleTree, IDeployableServer server) {
		String defaultFolder = publishMethod.getPublishDefaultRootFolder(server.getServer());
		String folder = PublishUtil.getDeployRootFolder(
				moduleTree, server, defaultFolder,
				IJBossToolingConstants.LOCAL_DEPLOYMENT_LOC);
		return PublishUtil.getDeployPath(moduleTree, folder);
	}

The behaviour here is that a module array is passed in. For dynwebapp.war, an IModule[] { dynewebModule} is passed in, and for webmodule.jar, an IModule[] { dynWebApp.war, webmodule.jar }  is passed in. The publish method for both calls should be the same.  The publishMethod.getPublishDefaultRootFolder(server.getServer()) call gets hte default root folder for this server. This result should return the same thing for both calls as the default root folder should not change between calls. 

The next call, folder = etc, tries to check if this module has a custom deploy folder separate from a default location, since the deployment page of a server can customize deployment location on its own. The impl of this method is in PublishUtil, and if you investigate that method you'll see that it only really checks the first module in the array, NONE of the children. So what this means is that this result, folder, should be the same for a call to the root war or its child jar project.

So above we can see that defaultFolder and folder should both be the same regardless of calls with one item (war) or two (child jar). Finally, the last call is to PublishUtil.getDeployPath(moduleTree, folder) and the impl here seems to look fine to me. I would be concerned if I saw any toString() calls on a Path or IPath object, but I don't see any. It seems it simply appends to the root folder the entire time. 

Tracing backwards, I simply cannot see how the passed in folder would be different, but I am not working in a windows environment so maybe I am missing it. Please give it a look if you have some time. Thanks. 

> Problem with deployment when Eclipse and JBoss AS are installed on different Windows drives
> -------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-7517
>                 URL: https://jira.jboss.org/browse/JBIDE-7517
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS
>    Affects Versions: 3.2.0.Beta1
>         Environment: Windows XP
>            Reporter: Snjezana Peco
>            Assignee: Snjezana Peco
>            Priority: Blocker
>             Fix For: 3.2.0.Beta2
>
>
> Steps to reproduce:
> - install Eclipse on one drive (C:, for instance) and JBoss AS on another (E:, for instance)
> - download the dynwebapp project attached to https://bugs.eclipse.org/bugs/show_bug.cgi?id=328974
> - start Eclipse 
> - deploy the project to JBoss AS
> The webmodule.jar module will be deployed to C:/<JBOSS_DEPLOY>/dynwebapp.war/WEB-INF/lib instead of to E:/<JBOSS_DEPLOY>/dynwebapp.war/WEB-INF/lib.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira