[jbosstools-issues] [JBoss JIRA] Issue Comment Edited: (JBIDE-7695) NPE when adding connection with invalid URL

[Andre Dietisheim (JIRA)]

    [ https://jira.jboss.org/browse/JBIDE-7695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564770#comment-12564770 ] 

Andre Dietisheim edited comment on JBIDE-7695 at 11/23/10 6:10 AM:
-------------------------------------------------------------------

The 2nd usecase, you report here uses a perfectly legal URI.According to RFC 3986, paragraph 3.2, the authority part in an URI is optional. An URL in the form http:/test lacks the authority part (http: := scheme, /test := path) and is legal but makes no sense as URL for a connection to deltacloud tools (how shall the tools reach a server with a relative URL?). 
The current behavior, where an error is reported, is perfectly correct. It may only be not userfriendly enough.
I moved the usecase with the single slash to its own issue: JBIDE-7714

      was (Author: adietish):
    The 2nd usecase, you report here uses a perfectly legal URI. According to RFC 3986, paragraph 3.2, the authority part in an URI is optional. An URL in the form http:/test lacks the authority part (http: := scheme, /test := path) is legal in terms of RFC 3986 but makes no sense as RUL for a connection to the deltacloud tools (how shall the tools reach a server with a relative URL?). 
The current behavior, where an error is reported, is perfectly correct. It may only be not userfriendly enough.
I moved the usecase with the single slash to its own issue: JBIDE-7714
  
> NPE when adding connection with invalid URL
> -------------------------------------------
>
>                 Key: JBIDE-7695
>                 URL: https://jira.jboss.org/browse/JBIDE-7695
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: deltacloud
>    Affects Versions: 3.2.0.Beta2
>         Environment: 3.2.0.v20101119-1705-H261-Beta2
>            Reporter: Libor Zoubek
>            Assignee: Andre Dietisheim
>             Fix For: 3.2.0.CR1
>
>         Attachments: .log
>
>
> If I enter total nonsense into url (like 'abc' '123'), the wizard dialogs stays open even though creating the connection failed. The dialog may be closed by hitting cancel. No error is displayed, but a NPE is in the log.
> There is one little issue related to this one.
> If I enter 'http://something' dialog gets closed and is treated like valid but not reachable connection. This is fine
> But if I enter 'http:/something' behavior is same, which is wrong, There is a need to fix regex determining valid or invalid URL.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira