[jbosstools-issues] [JBoss JIRA] Updated: (JBIDE-7732) fixe for JBIDE-3915 breaks version control for SCM that require checkout for writable files

[joe freeman (JIRA)]

     [ https://jira.jboss.org/browse/JBIDE-7732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

joe freeman updated JBIDE-7732:
-------------------------------

    Description: 
JBIDE-3915 tried to fix the issue where the JBPM xml editor fails when editing non-writable files.  The fix (015307?) in the URL below offers the user the opportunity to change the attributes from r/o to r/w bypassing the SCM hooks.  So for an SCM like Perforce where all files are locked until checkout, the user will have changed the R/W bits without notifying the SCM so they can save their changes but they never get committed back to the repository.  Users can lose changes without knowing it.

If you answer NO to the panel offered by JBIDE-3915 then the editor will still let you edit and when you save it will check out the processdefinition.xml in the SCM file like it used to and will fail on the gpd and jpg files (like it used to). 

The fix should have used the same Eclipse hooks used by the editor so that all 3 files end up checked out.  Changing the access bits directly seems like a bad idea

http://lists.jboss.org/pipermail/jbosstools-commits/2009-September/015307.html
https://jira.jboss.org/browse/JBIDE-3915

  was:
JBIDE-3915 tried to fix the issue where the JBPM xml editor fails when editing non-writable files.  The fix (015307?) in the URL below offers the user the opportunity to change the attributes from r/o to r/w bypassing the SCM hooks.  So for an SCM like Perforce where all files are locked until checkout, the user will have changed the R/W bits without notifying the SCM so they can save their changes but they never get committed back to the repository.  Users can lose changes without knowing it.

If you answer NO to the panel offered by JBIDE-1029 then the editor will still let you edit and when you save it will check out the processdefinition.xml in the SCM file like it used to and will fail on the gpd and jpg files (like it used to). 

The fix should have used the same Eclipse hooks used by the editor so that all 3 files end up checked out.  Changing the access bits directly seems like a bad idea

http://lists.jboss.org/pipermail/jbosstools-commits/2009-September/015307.html
https://jira.jboss.org/browse/JBIDE-3915



> fixe for JBIDE-3915 breaks version control for SCM that require checkout for writable files
> -------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-7732
>                 URL: https://jira.jboss.org/browse/JBIDE-7732
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: jbpm
>    Affects Versions: 3.2.0.M2
>         Environment: Eclipse 3.6 with JBPM 3 editor 3.2.0M2 probably introduced in 3.1 M3
>            Reporter: joe freeman
>            Assignee: Koen Aers
>            Priority: Minor
>             Fix For: LATER
>
>
> JBIDE-3915 tried to fix the issue where the JBPM xml editor fails when editing non-writable files.  The fix (015307?) in the URL below offers the user the opportunity to change the attributes from r/o to r/w bypassing the SCM hooks.  So for an SCM like Perforce where all files are locked until checkout, the user will have changed the R/W bits without notifying the SCM so they can save their changes but they never get committed back to the repository.  Users can lose changes without knowing it.
> If you answer NO to the panel offered by JBIDE-3915 then the editor will still let you edit and when you save it will check out the processdefinition.xml in the SCM file like it used to and will fail on the gpd and jpg files (like it used to). 
> The fix should have used the same Eclipse hooks used by the editor so that all 3 files end up checked out.  Changing the access bits directly seems like a bad idea
> http://lists.jboss.org/pipermail/jbosstools-commits/2009-September/015307.html
> https://jira.jboss.org/browse/JBIDE-3915

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira