[jbosstools-issues] [JBoss JIRA] Issue Comment Edited: (JBIDE-7393) Properties Editor -> Filter -> tooo complex logik for me

[Viacheslav Kabanovich (JIRA)]

    [ https://jira.jboss.org/browse/JBIDE-7393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559628#action_12559628 ] 

Viacheslav Kabanovich edited comment on JBIDE-7393 at 10/27/10 6:54 AM:
------------------------------------------------------------------------

Well, lets modify the simple search mode by the logic (* = any string, ? = any character, \ = escape for literals * ? \) and add this description to filter control.

As to the regular expression option, we have JBIDE-4576 with opinions in support of it, it has been implemented for more than a year, and there may be users who are used to it by now. Anyone who does not wish it, can keep it unchecked.

Here is a use-case wished in JBIDE-4576:
>Sometimes we must find exactly "date to". 
>Sometimes we must find "date to" everywhere in string.
Simple search provides only the second option. With regular expression you provide the first option by "^date to$". Is not it easy? And it is the standard if not in trivial Eclipse filters, than everywhere in Java.

      was (Author: scabanovich):
    Well, lets modify the simple search mode by the logic (* = any string, ? = any character, \ = escape for literals * ? \) and add this description to filter control.

As to the regular expression option, we have JBIDE-4576 with opinions in support of it, it has been implemented for more than a year, and there may be users who are used to it by now. Anyone who does not wish it, can keep it unchecked.
  
> Properties Editor -> Filter -> tooo complex logik for me
> --------------------------------------------------------
>
>                 Key: JBIDE-7393
>                 URL: https://jira.jboss.org/browse/JBIDE-7393
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: core
>    Affects Versions: 3.2.0.Beta2
>            Reporter: Vitali Yemialyanchyk
>            Assignee: Viacheslav Kabanovich
>            Priority: Minor
>         Attachments: screenshot-1.jpg
>
>
> I did not understand how this works, really. I do not so smart to print regular expression to search some property.
> I did not guess from the first look "Expression" means regular expression - I search JIRA to find what it mean and how it should work...
> I find JBIDE-4572, JBIDE-4576. 
> but really I do think what JBIDE-4576 is not about "real" regular expressions!
> it is just about support "*" and "?" - a good  example here is Ctrl-O search in Java files.
> the example how it works now - source file:
> hibernate.connection.driver_class=org.hsqldb.jdbcDriver
> hibernate.connection.password=
> hibernate.connection.url=jdbc:hsqldb:hsql://localhost/
> hibernate.connection.username=sa
> hibernate.dialect=org.hibernate.dialect.HSQLDialect
> hibernate.dialect222=org.hibernate.dialect.HSQLDialect222
> "di*2" - find nothing...
> so really my opinion - regular expressions here is options for genius...
> just simple  "*" and "?" support is necessary.
> "Case sensitive" - this option look like excessive.. - I wrote my opinion in JBIDE-4572 - 
> checkbox "Case sensitive" - is simple to understand - so it could be here.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira