[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-5901) Add JSF capabilities asks a lot of questions and uses *absolute* filepaths

[Viacheslav Kabanovich (JIRA)]

    [ https://jira.jboss.org/browse/JBIDE-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12551274#action_12551274 ] 

Viacheslav Kabanovich commented on JBIDE-5901:
----------------------------------------------

Add JSF capabilities was designed to convert to JSF project any project (later limited to Java project). It allowed to select required resources from outside of the project (e.g. if Java project has no web root, one can select it from anywhere on disk). Resources, thus picked, are not copied to project, just links to them are created. I checked this feature, it works. That behavior made adding capabilities and importing project to workspace very similar so that model support and ui are shared for these wizards:
1) web root: required both for importing and adding capabilities, can be filled exactly only for Web Dynamic project, otherwise can be guessed by web.xml, but user should have opportunity to check it.
2) Source and classes folders are required for importing, in adding capabilities they are filled exactly since we consider only Java projects. 
3) Lib: it is WEB-INF/lib folder, but for importing/converting a project without libs it can be selected from outside.

This wizard sharing has its advantages, but in view of this issue, it has drawbacks as well:
1) if web root is located inside the project, absolute path choosing is weird (the case of external web root maybe is of no interest now)
2) Selecting of source and classes folders are not needed in adding capabilities;
3) Selecting lib folder in adding capabilities (and maybe even in importing) is obsolete because at present libs are taken from server run-times. 

It should be mentioned, that absolute path choosing does not affect the result of adding capabilities to existing project, if selected resources need not to be linked, the project will not keep references to them as absolute paths. So, absolute path choosing is only a problem of user interface.

Fixing 2),3) is not difficult - we may just hide 'Source', 'Class', 'Lib' input fields in case of adding capabilities.

Fixing 1) is not so simple, in that case we cannot reuse import wizard as add capabilities wizard, but have to re-implement it; and with that throw away the case of external web root.

An argument in favor that it is not so critical issue is that when web-root can be guessed (100% for Web Dynamic project, 90% otherwise by position of web.xml), user may disregard these input fields and just press 'Finish'. So, it is more an issue of presentation.

> Add JSF capabilities asks a lot of questions and uses *absolute* filepaths
> --------------------------------------------------------------------------
>
>                 Key: JBIDE-5901
>                 URL: https://jira.jboss.org/browse/JBIDE-5901
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JSF
>    Affects Versions: 3.1.0.CR1
>            Reporter: Max Andersen
>            Assignee: Viacheslav Kabanovich
>             Fix For: 3.3.x
>
>
> When Adding JSF support to an existing project i'm asked about *alot* of questions which seems irrelevant/outofdate plus it lists absolute file names.
> Web Root is fair to ask about, but why the full path ?
> Source and classes folder should be a given when its a Java Project anyway ?
> lib folder ? no idea what that is.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira