[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-7021) Low perfomance of validation for web pages

[Snjezana Peco (JIRA)]

    [ https://jira.jboss.org/browse/JBIDE-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12551772#action_12551772 ] 

Snjezana Peco commented on JBIDE-7021:
--------------------------------------

I have found the following issues:

1) The PageContextFactory.createPageContext(IFile file, List<String> parents, String defaultContextType) method creates SSE model for a non-facelet page.
The attached patch fixes this problem. Validation will be faster when the project contains a lot of non-facelet pages.

2) Another problem happens when some page contains EL errors/warnings. ValidationErrorManage.addError(...) notifies marker resource change and PageContextFactory cleans the cache. If there is a complex El expression, PageConteXtFactory creates context (SSE model, ...) again for the same page. The problem is fixed within the patch

This speeds up building/validation of the projects that I have tested (for about 50%). It should be pointed out that it includes EL validator that is the slowest.

3) XJob can notify a resource change and PageContextFactory cleans the cache, but I not sure if we can suspend XJob so I haven't tried to fix this problem.

4) There is a memory leak in the PageContextFactory.getSheetForTagAttribute(final Node stylesContainer, String attribute) method. This method registers the ExtendedLinkElementAdapter adapter, but never releases it. I have fixed this bug partially (for an invalid CSS sheet). 

> Low perfomance of validation for web pages
> ------------------------------------------
>
>                 Key: JBIDE-7021
>                 URL: https://jira.jboss.org/browse/JBIDE-7021
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: jsp/jsf/xml source editing
>    Affects Versions: 3.2.0.Beta
>            Reporter: Maxim Areshkau
>            Assignee: Alexey Kazakov
>             Fix For: 3.2.0.Beta
>
>         Attachments: jbide7021.patch
>
>
> #1 import project https://svn.jboss.org/repos/jbosstools/trunk/jsf/tests/org.jboss.tools.jsf.vpe.jsf.test/resources/jsfTest into workspace;
> #2 try to call validate on jsfTest/WebContent
> #3 it takes about 60-90 seconds to validate this folder whith JBoss Tools plugins and 7-13 seconds without JBoss Tools just with WPT installed.
> So looks like we need to do smth for speeding up the validation process.
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira