[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-7146) Single file deployable factory saves every project after any change

Rob Stryker (JIRA) jira-events at lists.jboss.org
Thu Sep 23 19:41:04 EDT 2010


    [ https://jira.jboss.org/browse/JBIDE-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12552859#action_12552859 ] 

Rob Stryker commented on JBIDE-7146:
------------------------------------

To explain the patch a bit:

The bug was that making a file in ProjectA deployable or undeployable would save a blank setting in ProjectB, ProjectC, ProjectD etc. The patch still appears to save an empty .settings file in ProjectA if ProjectA has no deployable files, however, this will only happen if ProjectA had a file marked deployable, and then later marked that file undeployable, leaving 0 remaining deployable files. In this case, the setting still needs to be saved, because to *not* save it would leave ProjectA/file1 as deployable in the settings file even though you just marked it as undeployable.

1) So, the bug of having 15 projects change on every mark / unmark deployable has been fixed. Now only the project that has changed will have a settings file changed
2) If ProjectA has had a file's status change TO deployable, the settings file should obviously be changed to mark this
3) If ProjectA has had a file's status change to NOT deployable, the settings file should still obviously be changed to remove the previously-set attribute. 

Hope that helps clarify. 

> Single file deployable factory saves every project after any change
> -------------------------------------------------------------------
>
>                 Key: JBIDE-7146
>                 URL: https://jira.jboss.org/browse/JBIDE-7146
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS
>    Affects Versions: 3.2.0.M2
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 3.2.0.Beta1
>
>
> All projects in the workspace get the setting after any file is marked deploiyable. This is bad. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the jbosstools-issues mailing list