[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-8687) JSF tooling adds an Faces Servlet declaration with no servlet mappings on project import

[Snjezana Peco (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596538#comment-12596538 ] 

Snjezana Peco commented on JBIDE-8687:
--------------------------------------

> May it be reasonable to add correct set of mappings for JSF 2.0 projects in MavenJSFActivator, 
> otherwise JSF facet install delegate adds to web.xml faces servlet declaration without servlet mapping.

Re the Maven JSF configurator, I can do the following for JSF 2.0:

- check if there are servlet declaration and servlet mapping before adding the JSF facet
If they don't exist, remove them after adding the JSF facet in the case it added them.
Do you agree?

> JSF tooling adds an Faces Servlet declaration with no servlet mappings on project import
> ----------------------------------------------------------------------------------------
>
>                 Key: JBIDE-8687
>                 URL: https://issues.jboss.org/browse/JBIDE-8687
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JSF, UpStream
>    Affects Versions: 3.2.0.Final
>            Reporter: Dan Allen
>            Assignee: Viacheslav Kabanovich
>            Priority: Blocker
>             Fix For: 3.2.1, 3.3.0.M1
>
>
> When importing a Java EE 6 webapp that contains a faces-config.xml descriptor, the JSF tooling unnecessarily adds a Faces Servlet declaration to the web.xml. The Faces Servlet is not required in Java EE 6 (at least on JBoss AS and GlassFish). What's worse, the Servlet is added with no mappings, so it completely breaks JSF.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira