[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-9345) AS7: remove unneeded additional indirection in service usage

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-9345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620006#comment-12620006 ] 

Andre Dietisheim commented on JBIDE-9345:
-----------------------------------------

Major parts of this indirection have been removed. The only thing that is still present is a management component (AS7Manager) that is configured to a specific host and port in its consructor (where the as7 client is created). All its methods dont offer any port/host. On the other hand, the management service that is used by our adapter offers host&port in all methods. It therefore instantiates a management component in all its methods. It might be a further simplification to merge the management component and the service(-wrapper).

> AS7: remove unneeded additional indirection in service usage
> ------------------------------------------------------------
>
>                 Key: JBIDE-9345
>                 URL: https://issues.jboss.org/browse/JBIDE-9345
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: JBossAS
>    Affects Versions: 3.3.0.M3
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>             Fix For: 3.3.x
>
>
> AS tooling uses an osgi service to interact with the as7 server. This service is implemented in AS7Manager. This manager is not directly exposed but there's an additional indirection to it: JBoss7ManagerService. JBoss7ManagerService basically only instantiates AS7Manager and calls the appropriate method on it. This was initially done because we thought about offerding additional functionalities which did not work out. We should now remove this additional indirection/wrapping since there's no sense to it, it only makes code harder to read.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira