[jbosstools-issues] [JBoss JIRA] Updated: (JBIDE-9518) WebPortPoller #onePing swallows Exceptions without any logging

[Andre Dietisheim (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andre Dietisheim updated JBIDE-9518:
------------------------------------

    Description: 
WebPortPoller#onePing swallows a plain Exception without at least logging it.
See https://source.jboss.org/cru/REV-JBIDE-4/#c23

{code}
	private static boolean onePing(String url) {
		try {
			URL pingUrl = new URL(url);
			URLConnection conn = pingUrl.openConnection();
			((HttpURLConnection)conn).getResponseCode();
			return true;
		} catch( FileNotFoundException fnfe ) {
			return true;
		} catch( Exception e) {
		}
		return false;
	}
{code}



  was:
{code}
	private static boolean onePing(String url) {
		try {
			URL pingUrl = new URL(url);
			URLConnection conn = pingUrl.openConnection();
			((HttpURLConnection)conn).getResponseCode();
			return true;
		} catch( FileNotFoundException fnfe ) {
			return true;
		} catch( Exception e) {
		}
		return false;
	}
{code}





> WebPortPoller #onePing swallows Exceptions without any logging
> --------------------------------------------------------------
>
>                 Key: JBIDE-9518
>                 URL: https://issues.jboss.org/browse/JBIDE-9518
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: JBossAS
>    Affects Versions: 3.3.0.M3
>            Reporter: Andre Dietisheim
>            Assignee: Rob Stryker
>             Fix For: 3.3.x
>
>
> WebPortPoller#onePing swallows a plain Exception without at least logging it.
> See https://source.jboss.org/cru/REV-JBIDE-4/#c23
> {code}
> 	private static boolean onePing(String url) {
> 		try {
> 			URL pingUrl = new URL(url);
> 			URLConnection conn = pingUrl.openConnection();
> 			((HttpURLConnection)conn).getResponseCode();
> 			return true;
> 		} catch( FileNotFoundException fnfe ) {
> 			return true;
> 		} catch( Exception e) {
> 		}
> 		return false;
> 	}
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira