[jbosstools-issues] [JBoss JIRA] Issue Comment Edited: (JBIDE-9339) VPE should have better exceptions handling related to third party templates

[Denis Maliarevich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621561#comment-12621561 ] 

Denis Maliarevich edited comment on JBIDE-9339 at 8/17/11 7:17 AM:
-------------------------------------------------------------------

Due to the fact that VPE templates have been put inside VpeTemplateSafeWrapper, some VPE logic fails. 

Such as toggling, for instance in VpeVisualDomBuilder line 1041:
if (template instanceof VpeToggableTemplate) {..} fails and toggling is skipped.

So some solution should be found. Probably we should keep VpeTemplateSafeWrapper, but then all the other VPE code should be updated.


      was (Author: dmaliarevich):
    Because of the VPE templates have been put inside VpeTemplateSafeWrapper now, some VPE logic fails. 

Such as toggling, for instance in VpeVisualDomBuilder line 1041:
if (template instanceof VpeToggableTemplate) {..} fails and toggling is skipped.

So some solution should be found. Probably we should keep VpeTemplateSafeWrapper, but then all the other VPE code should be updated.

  
> VPE should have better exceptions handling related to third party templates
> ---------------------------------------------------------------------------
>
>                 Key: JBIDE-9339
>                 URL: https://issues.jboss.org/browse/JBIDE-9339
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Visual Page Editor core, Visual Page Editor Templates
>    Affects Versions: 3.3.0.M3
>            Reporter: Vitali Yemialyanchyk
>            Assignee: Denis Golovin
>            Priority: Trivial
>             Fix For: 3.3.0.M3
>
>         Attachments: hs_err_pid9748.log, JBIDE-9339_20110713.patch, screenshot-1.jpg
>
>
> Guys I can not imagine how you handle/find such real life issues in VPE like I get last time. Now I know this is my issue in my plugable VPE template (it was NPE exception) - but how I find this?! This is a really epic story. No exceptions in Error Log - just Eclipse "graceful" crash with this log in console:
> >>>
> Configuration location:
>     file:/C:/_ws/xx_vpe/.metadata/.plugins/org.eclipse.pde.core/New_configuration/
> Configuration file:
>     file:/C:/_ws/xx_vpe/.metadata/.plugins/org.eclipse.pde.core/New_configuration/config.ini loaded
> Install location:
>     file:/C:/Bin/eclipse_3.7/
> Framework located:
>     file:/C:/Bin/eclipse_3.7/plugins/org.eclipse.osgi_3.7.0.v20110613.jar
> Loading extension: reference:file:javax.transaction_1.1.1.v201105210645.jar
> 	eclipse.properties not found
> Framework classpath:
>     file:/C:/Bin/eclipse_3.7/plugins/org.eclipse.osgi_3.7.0.v20110613.jar
>     file:/C:/Bin/eclipse_3.7/plugins/
>     file:/C:/Bin/eclipse_3.7/plugins/javax.transaction_1.1.1.v201105210645.jar
> Splash location:
>     C:\Bin\eclipse_3.7\plugins\org.eclipse.platform_3.7.0.v201106131736\splash.bmp
> Debug options:
>     file:/C:/_ws/xx_vpe/.metadata/.plugins/org.eclipse.pde.core/New_configuration/.options loaded
> Time to load bundles: 94
> Starting application: 6839
> !SESSION 2011-07-13 19:56:53.561 -----------------------------------------------
> eclipse.buildId=I20110613-1736
> java.version=1.6.0_24
> java.vendor=Sun Microsystems Inc.
> BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=en_US
> Framework arguments:  -product org.eclipse.sdk.ide
> Command-line arguments:  -product org.eclipse.sdk.ide -data C:\_ws\xx_vpe/../runtime-New_configuration -dev file:C:/_ws/xx_vpe/.metadata/.plugins/org.eclipse.pde.core/New_configuration/dev.properties -debug C:\_ws\xx_vpe\.metadata\.plugins\org.eclipse.pde.core\New_configuration/.options -os win32 -ws win32 -arch x86 -consoleLog
> !ENTRY org.eclipse.mylyn.tasks.ui 2 0 2011-07-13 19:57:06.090
> !MESSAGE No search provider was registed. Tasks search is not available.
> Application Started: 29190
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> #  EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x642c902e, pid=9748, tid=9460
> #
> # JRE version: 6.0_24-b07
> # Java VM: Java HotSpot(TM) Client VM (19.1-b02 mixed mode, sharing windows-x86 )
> # Problematic frame:
> # C  [js3250.dll+0x4902e]
> #
> # An error report file with more information is saved as:
> # C:\Bin\eclipse_3.7\hs_err_pid9748.log
> #
> # If you would like to submit a bug report, please visit:
> #   http://java.sun.com/webapps/bugreport/crash.jsp
> # The crash happened outside the Java Virtual Machine in native code.
> # See problematic frame for where to report the bug.
> #
> >>>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira