[jbosstools-issues] [JBoss JIRA] (JBIDE-10228) org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik with Image dispose

[Viacheslav Kabanovich (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647327#comment-12647327 ] 

Viacheslav Kabanovich commented on JBIDE-10228:
-----------------------------------------------

This dialog may create even more new images at start. 'Property Sheet' tab has 8 color attributes. If they are set, they are also added to 'Edited properties' tab, which is fully loaded at start. In this case dialog creates at start 1518 new images and then 1104 each time you switch to 'Edited properties' tab.
                
> org.jboss.tools.jst.css.dialog.widgets.ImageCombo has incorrect logik with Image dispose
> ----------------------------------------------------------------------------------------
>
>                 Key: JBIDE-10228
>                 URL: https://issues.jboss.org/browse/JBIDE-10228
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: common/jst/core
>    Affects Versions: 3.3.0.M4
>            Reporter: Vitali Yemialyanchyk
>            Assignee: Viacheslav Kabanovich
>             Fix For: 3.3.0.Beta1
>
>         Attachments: jbide-10228.patch
>
>
> line 226:
> {code}
> public void add(String string, Image image) {
> ...
>         if (image != null) {
>             newItem.setImage(image);                                     <----------- here you get image if it not null
>         }
>         newItem.addDisposeListener(new DisposeListener() {
>                 public void widgetDisposed(DisposeEvent e) {
>                     TableItem item = (TableItem) e.getSource();
>                     item.getImage().dispose();                            <----------- here you dispose image in any case
>                 }
>             });
> ...
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira