[jbosstools-issues] [JBoss JIRA] (JBIDE-9932) Fix VpeDomMapping.getNodeMappingAtVisualNode to use HashMap.get instead of iteration

[Denis Maliarevich (Issue Comment Edited) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647431#comment-12647431 ] 

Denis Maliarevich edited comment on JBIDE-9932 at 12/2/11 3:11 AM:
-------------------------------------------------------------------

1 failure is connected with the "render" attribute. See JBIDE-4179. Now EL didn't evaluate #{false} to false.
12 failures -- due to VpeNodeMappings creation not in a good time. Thus for instance for rendering <f:facet> to its parent -- visual node for the parent hasn't been registered in the mapping yet. Because "registerNodes(elementMapping);" was moved to "addNode(..)" method.
                
      was (Author: dmaliarevich):
    1 failure is connected with the "render" attribute. See JBIDE-4179. Now EL didn't evaluate #{false} to false.
12 failures -- due to VpeNodeMappings creation not in a good time. Thus for instance for rendering f:facet to the its parent -- visual node for the parent hasn't been registered yet. Because "registerNodes(elementMapping);" was moved to "addNode(..)" method.
                  
> Fix VpeDomMapping.getNodeMappingAtVisualNode to use HashMap.get instead of iteration
> ------------------------------------------------------------------------------------
>
>                 Key: JBIDE-9932
>                 URL: https://issues.jboss.org/browse/JBIDE-9932
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Visual Page Editor core
>    Affects Versions: 3.3.0.M4
>            Reporter: Denis Golovin
>            Assignee: Denis Maliarevich
>             Fix For: 3.3.0.M5
>
>         Attachments: JBIDE-9932-Draft1.patch, JBIDE-9932-Draft2-wTests.patch
>
>
> nsIDOMNode.appendChild(nsIDOMNode child) actually adds copy of child provided and returns it as result. VPE saves in map a child passed as parameter instead of actually added node returned from appendChild method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira