[jbosstools-issues] [JBoss JIRA] (JBDS-1941) Welcome screen - Getting Started

Victor Rubezhny (Commented) (JIRA) jira-events at lists.jboss.org
Fri Dec 2 07:20:40 EST 2011


    [ https://issues.jboss.org/browse/JBDS-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647517#comment-12647517 ] 

Victor Rubezhny commented on JBDS-1941:
---------------------------------------

Editor input, actually org.jboss.tools.central.editors.JBossCentralEditorInput, required to open JBossCentralEditor. I cannot pass null as editor input value because it's Illegal:
{code}
java.lang.IllegalArgumentException
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2784)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2773)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2756)
	at com.jboss.jbds.product.intro.action.OpenJBossCentralEditor.openJBossCentralEditor(OpenJBossCentralEditor.java:45)
{code}

If I'll try to substitute JBossCentralEditorInput class by some other editor input class I'll face PartInitException because of the following code in org.jboss.tools.central.editors.JBossCentralEditor.init(IEditorSite, IEditorInput):
{code}
		if (!(editorInput instanceof JBossCentralEditorInput))
			throw new PartInitException(
					"Invalid Input: Must be JBossCentralEditorInput");
{code}

Actually, if not prohibited by preferences, JBossCentralEditor is to be opened anyway on first run, but it may not be opened in case it's preferences were modified.

Another problem is to make the "button" centered. I'd rather put the link icon and text in one line (not link text above the icon), because as it's done now, the link (icon and text) have static position on the page (resizing the page doesn't move the link) - less harm to overall view.
                
> Welcome screen - Getting Started
> --------------------------------
>
>                 Key: JBDS-1941
>                 URL: https://issues.jboss.org/browse/JBDS-1941
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 5.0.0.M3
>         Environment: Mac OS X Lion 64-bit - Note: 5.0.0.M4 (but it was not in the Affects version list)
>            Reporter: Burr Sutter
>            Assignee: Victor Rubezhny
>            Priority: Blocker
>             Fix For: 5.0.0.M5
>
>         Attachments: asDesigned.png, justGettingStarted.png, Screen Shot 2011-11-29 at 4.41.59 PM.png
>
>
> JBDS5.M4's current Welcome Screen:
> - the text at the top of the screen says
> "tools that are pre-configured for JBoss Enterprise Middleware Platforms and Red Hat Linux".
> The tools are not pre-configured for Red Hat Linux, I am running them on Mac and Windows! 
> How about "..and certified on Red Hat Linux".
> - includes two links to Getting Started and is out of alignment.
> 1 Getting Started with JBoss Developer Studio
> 2 Getting Started with JBoss Developer Studio
> 3 Getting Started
> 4  JBoss Seam Tutorial
> 5  WTP J2EE Tutorials
> 1 - The first item does not take you to the Getting Started element in the docset. I am not sure if that specific book has a direct link, if possible link directly to the right book.
> 2 - The 2nd item is simply the same text without a link - just remove the redundant text.
> 3 - The 3rd item takes you to the workshops listing.  Those are not updated to JBDS5. This should not be a link
> 4 - Correctly linked - in the future I hope to have some EE6 Getting Started materials to add here
> 5 - J2EE? Please kill this link - we must leverage our AS7 Getting Started materials, videos, quickstarts, archetypes.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the jbosstools-issues mailing list