[jbosstools-issues] [JBoss JIRA] (JBIDE-10297) Workspace set to default even if set differently

[Snjezana Peco (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647886#comment-12647886 ] 

Snjezana Peco commented on JBIDE-10297:
---------------------------------------

> But a patch that thread.sleeps 500 ms cannot be the right solution. Only an M5 minimal fix.

> Would be more relevant to figure out why IJBoss7ManagerService needs to be started this early and aggressively.

Because it is a declarative service. All declarative services are being initialized by the org.eclipse.equinox.ds plugin that starts at startLevel 2 (before all except the system.bundle and org.eclipse.equinox.simpleconfigurator plugin).

This issue could be solved in a several way:

- make IJBoss7ManagerService doesn't depend on the core.as plugin (not sure if this is doable)
- convert it to a non-declarative service and load it lazily
- make a workaround as in the proposed patch

IMO the third solution is the easiest one. Thread.sleep(500) only happens when the IDE opens the Workspace Launcher dialog and waits for the user to finish the dialog. I think, making it sleep for <=0.5 seconds while waiting for the user input wouldn't make a problem. That happens in a job and will postpone starting the as.core plugin which is what we want. This would also solve some other potential issues that aren't related to this service (when some other code tries to start the as.core plugin too early).
                
> Workspace set to default even if set differently
> ------------------------------------------------
>
>                 Key: JBIDE-10297
>                 URL: https://issues.jboss.org/browse/JBIDE-10297
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS/Servers
>         Environment: JBoss Tools 3.3.0 Nightly (2011-11-30_14-04-32-H4078)
> Mac + Ubuntu
>            Reporter: Martin Malina
>            Assignee: Alexey Kazakov
>            Priority: Blocker
>             Fix For: 3.3.0.M5
>
>         Attachments: jbide-10297.patch
>
>
> Before I installed JBoss Tools into Eclipse workspaces worked fine - Eclipse asks which workspace to use at start time.
> Once I installed JBoss Tools, Eclipse stopped asking me for workspace location on startup. Even if I change the workspace it falls back to default on the next start of Eclipse.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira