[jbosstools-issues] [JBoss JIRA] (JBIDE-10318) EJB jar projects are deployed as exploded jars in war/WEB-INF/lib

[Rob Stryker (Issue Comment Edited) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648280#comment-12648280 ] 

Rob Stryker edited comment on JBIDE-10318 at 12/6/11 2:43 AM:
--------------------------------------------------------------

Hi Mike!

Thanks for the patch!  I've modified it a little. Your understanding was spot on! I, however, choose to force a zipped nesting if it's inside anything EXCEPT an ear... I imagine if someone tried to place it inside a utility project, or an esb project, they would probably want it zipped too :) 

Perhaps I'm wrong, but for now, this seems the safest path.  

I'll try to get this into a build ASAP!  Thanks! 

{code:title=patch|borderStyle=solid}
@@ -313,6 +313,11 @@
 			return true;
 		} else if( moduleTypeId.equals(IWTPConstants.FACET_WEB_FRAGMENT)) {
 			return true;
+		} else if( moduleTypeId.equals(IWTPConstants.FACET_EJB) && moduleTree.length > 1) {
+			 String parentModuleTypeId = moduleTree[moduleTree.length - 2].getModuleType().getId(); 
+			 if( !parentModuleTypeId.equals(IWTPConstants.FACET_EAR)) {
+				 return true; 
+			 }
 		}
 		return false;
 	}
{code}
                
      was (Author: rob.stryker):
    Hi Mike!

Thanks for the patch!  I've modified it a little. Your understanding was spot on! I, however, choose to force a zipped nesting if it's inside anything EXCEPT an ear... I imagine if someone tried to place it inside a utility project, or an esb project, they would probably want it zipped too :) 

Perhaps I'm wrong, but for now, this seems the safest path.  

I'll try to get this into a build ASAP!  Thanks! 

{{@@ -313,6 +313,11 @@
 			return true;
 		} else if( moduleTypeId.equals(IWTPConstants.FACET_WEB_FRAGMENT)) {
 			return true;
+		} else if( moduleTypeId.equals(IWTPConstants.FACET_EJB) && moduleTree.length > 1) {
+			 String parentModuleTypeId = moduleTree[moduleTree.length - 2].getModuleType().getId(); 
+			 if( !parentModuleTypeId.equals(IWTPConstants.FACET_EAR)) {
+				 return true; 
+			 }
 		}
 		return false;
 	}
}}
                  
> EJB jar projects are deployed as exploded jars in war/WEB-INF/lib
> -----------------------------------------------------------------
>
>                 Key: JBIDE-10318
>                 URL: https://issues.jboss.org/browse/JBIDE-10318
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS/Servers
>    Affects Versions: 3.3.0.M4
>            Reporter: Mike Mosiewicz
>            Assignee: Rob Stryker
>            Priority: Blocker
>              Labels: deployment, ejb
>
> EJB jars deployed in WAR's WEB-INF/lib are exploded. That cause errors. Everything in WEB-INF/lib should be zipped. This is similiar to JBIDE-9836.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira