[jbosstools-issues] [JBoss JIRA] (JBIDE-10357) Add listeners in VpeController to support full/partial VPE refresh monitoring.

[Maxim Shmidov (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648386#comment-12648386 ] 

Maxim Shmidov commented on JBIDE-10357:
---------------------------------------

1. Of course it will be better to move method call outside of if/else clause, but i fear the potential implications of adding listeners to running job before cancelling it (else scenario). Of course it is possible to refactor this clause, but i was trying to make changes as little as possible.

2. ListenerList will throw IllegalArgumentException in case of null argument. I think you're right, null check is not needed here.
                
> Add listeners in VpeController to support full/partial VPE refresh monitoring.
> ------------------------------------------------------------------------------
>
>                 Key: JBIDE-10357
>                 URL: https://issues.jboss.org/browse/JBIDE-10357
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: Visual Page Editor core
>    Affects Versions: 3.3.0.Beta1
>            Reporter: Maxim Shmidov
>            Assignee: Yahor Radtsevich
>         Attachments: VpeController.java.patch
>
>
> In some cases i need to know when VPE intitiates or finishes visual refresh. Implementation of required listeners is very simple, and i already have a patch with this functionality.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira