[jbosstools-issues] [JBoss JIRA] (JBIDE-9934) handle the case where a project already exist with the same name

Andre Dietisheim (Issue Comment Edited) (JIRA) jira-events at lists.jboss.org
Thu Dec 8 13:21:41 EST 2011


    [ https://issues.jboss.org/browse/JBIDE-9934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649335#comment-12649335 ] 

Andre Dietisheim edited comment on JBIDE-9934 at 12/8/11 1:21 PM:
------------------------------------------------------------------

there are 2 cases that cause things to fail:

1) There's a project in the workspace, that has the very same name as the name that's in the maven pom. The maven importer will then just refuse to import the OpenShift project. It will not throw an Exception but simply wont do anything.

2) the git clone destination folder already has a folder with the very same name as the OpenShift application. The current code would just overwrite that clone.

1) can only be handled correctly if we analyze the pom and find out about the maven name of the application. M5's too close to do that. I suggest that I simply watch the maven import and check if it imported anything. If not, I'll inform the user accordingly telling him that the maven import failed and the most obvious cause was an identical project in workspace.

2)should get handled by a warning/error marker on the git clone destination text-field and disable the finish button. M5's too close to do that. I suggest that we simply inform the user with a warning dialog telling him that the clone was not executed since it would have killed his prior checkout.

                
      was (Author: adietish):
    there are 2 cases that cause things to fail:

1) There's a project in the workspace, that has the very same name as the name that's in the maven pom. The maven importer will then just refuse to import the OpenShift project

2) the git clone destination folder already has a folder with the very same name as the OpenShift application. The current code would just overwrite that clone.

1) can only be handled correctly if we analyze the pom and find out about the maven name of the application. M5's too close to do that. I suggest that I simply watch the maven import and check if it imported anything. If not, I'll inform the user accordingly telling him that the maven import failed and the most obvious cause was an identical project in workspace.

2)should get handled by a warning/error marker on the git clone destination text-field and disable the finish button. M5's too close to do that. I suggest that we simply inform the user with a warning dialog telling him that the clone was not executed since it would have killed his prior checkout.

                  
> handle the case where a project already exist with the same name
> ----------------------------------------------------------------
>
>                 Key: JBIDE-9934
>                 URL: https://issues.jboss.org/browse/JBIDE-9934
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>            Reporter: Max Rydahl Andersen
>            Assignee: Max Rydahl Andersen
>             Fix For: 3.3.0.M5
>
>         Attachments: check-paths.patch, check-paths2.patch
>
>
> when you import a project via openshift it does not handle the case where a project of the same name already exist. It does warn you but then the wizard "crashes".
> Two tests: 
>  Import the same openshift app twice.
> or 
>  create a project with same name
>  then import openshift app with project with same name.
> Needs to be tested for both the maven and general import scenario.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the jbosstools-issues mailing list