[jbosstools-issues] [JBoss JIRA] (JBIDE-10494) Unit test weirdness in ServerBeanLoader for EAP6

[Snjezana Peco (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651593#comment-12651593 ] 

Snjezana Peco commented on JBIDE-10494:
---------------------------------------

> If you look at ServerBeanLoaderTest.testEAP60, you will see a failure inside a try/catch statement. 
> The question here ultimately is what should ServerBeanLoader.getFullServerVersion reply when presented 
> with an EAP6 installation: the EAP version? Or the AS version? 

IMO, it should return the EAP version.
Attached is a patch that fixed the issue in the AS plugins and in the AS Runtime detector. Tested with EAP6 DR8.
                
> Unit test weirdness in ServerBeanLoader for EAP6
> ------------------------------------------------
>
>                 Key: JBIDE-10494
>                 URL: https://issues.jboss.org/browse/JBIDE-10494
>             Project: Tools (JBoss Tools)
>          Issue Type: Task
>          Components: JBossAS/Servers
>    Affects Versions: 3.3.0.Beta1
>            Reporter: Rob Stryker
>            Assignee: Snjezana Peco
>             Fix For: 3.3.0.Beta1
>
>         Attachments: jbide-10494.patch
>
>
> I added some unit tests when working on JBIDE-9724, and discovered some unit test weirdness when dealing with EAP 6.0.  Basically, it cannot confirm the full version. It comes back with 7.1.  
> If the task was simple, I would simply fix the code (as I did with the EAP6 condition class), but in this case, the logic to discover the version is hard-coded in the ServerBeanLoader with no reference to a ServerType, and so no way to customize the logic per server type. If it were entirely my code, I'd go ahead and change it, but I know others use this, and wanted to solicit input. 
> If you look at ServerBeanLoaderTest.testEAP60, you will see a failure inside a try/catch statement.  The question here ultimately is what should ServerBeanLoader.getFullServerVersion reply when presented with an EAP6 installation:  the EAP version? Or the AS version? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira