[jbosstools-issues] [JBoss JIRA] (JBIDE-10310) Check if there is event related to document root in the VPE queue and process it skipping other ones

[Denis Golovin (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652375#comment-12652375 ] 

Denis Golovin commented on JBIDE-10310:
---------------------------------------

This is not correct patch in many ways:
1. Current revision in trunk is
{code}

eskimo at dgolovin-desktop:~/Projects/jbds-build$ svn info  jbosstools-src/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/VpeController.java
Path: jbosstools-src/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/VpeController.java
Name: VpeController.java
URL: https://svn.jboss.org/repos/jbosstools/trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/VpeController.java
Repository Root: https://svn.jboss.org/repos/jbosstools
Repository UUID: a6e63f8b-b82e-0410-b459-8049accddafe
Revision: 37464
Node Kind: file
Schedule: normal
Last Changed Author: dgolovin
Last Changed Rev: 37199
Last Changed Date: 2011-12-09 17:03:53 -0800 (Fri, 09 Dec 2011)
Text Last Updated: 2011-12-09 13:05:03 -0800 (Fri, 09 Dec 2011)
Checksum: 926b580323d4b0b52c1abd9a449a8d4c
{code}
2. It is again has refactoring in patch which makes it difficult to review

Would you attach a patch with both issues above fixed?
Thanks

                
> Check if there is event related to document root in the VPE queue and process it skipping other ones
> ----------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-10310
>                 URL: https://issues.jboss.org/browse/JBIDE-10310
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: Visual Page Editor core
>    Affects Versions: 3.3.0.M5
>            Reporter: Denis Golovin
>            Assignee: Yahor Radtsevich
>            Priority: Minor
>             Fix For: 3.3.0.Beta1
>
>         Attachments: JBIDE-10310_20111220.patch, screenshot-1.jpg
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira