[jbosstools-issues] [JBoss JIRA] (JBIDE-10541) If I add a file to my project, the OpenShift server adapter will not add/commit it

[Rob Stryker (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652697#comment-12652697 ] 

Rob Stryker commented on JBIDE-10541:
-------------------------------------

Here are the categories of files that we can choose to commit on the commit operation:

- getAdded()
- getChanged()
- getConflicting()
- getMissing()
- getModified()
- getRemoved()
- getUntracked()

The question then is which of these should be added to the commit list.  "Added" does not actually count as new files, as the initial state of any new file is "untracked".  However automatically adding any and all "untracked" resources seems like a bad idea in general. However I, of course, am willing to do whatever makes sense here. If you all tell me it only makes sense that the default behaviour is to commit *EVERYTHING*, then I will have it commit any and all changes. 

I believe the most logical behaviour is to commit files that were added, changed, modified, or removed.  I believe conflicting, missing, and untracked, should not be added by our publish method by default.  The other option, of course, is to have options for this in the server adapter somewhere, either in the editor or in a properties page. I would also be ok with this solution, but this, of course, depends on our server editor / properties UI modifications, which seek to find out if settings such as these belong in the server editor or in the properties page. 

Either way, passing this list of files to the CommitOperation is not a hard task. We need only to discover what the proper default behaviour should be, and what level of control is available to the user. 

I vote for no UI dialog during a commit (annoying), these settings with checkboxes listed in the PROPERTIES page, etc.  
                
> If I add a file to my project, the OpenShift server adapter will not add/commit it
> ----------------------------------------------------------------------------------
>
>                 Key: JBIDE-10541
>                 URL: https://issues.jboss.org/browse/JBIDE-10541
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 3.3.0.M5
>            Reporter: Andre Dietisheim
>            Assignee: Rob Stryker
>             Fix For: 3.3.0.Beta1
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira