[jbosstools-issues] [JBoss JIRA] (JBIDE-7361) Seam toolbar items are showing up in the Teiid toolbar

[Victor Rubezhny (Issue Comment Edited) (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-7361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652873#comment-12652873 ] 

Victor Rubezhny edited comment on JBIDE-7361 at 12/22/11 4:18 PM:
------------------------------------------------------------------

I'm sorry Max. It works and could be made visible on any perspective. Due to enable Open Seam Component handler in Toolbar/Menu you have to enable "Seam UI" command group first and then you'll be able to enable the command itself. 
It confused me because it required me to close "Customize Perspective..." dialog by pressing "OK" button before "Open Seam Component" has become able to be enabled.

So, the enablement on perspectives 'others than Seam perspective' works.


On "selective enablement"... If I understand your question right:

The "Open Type" in JDT is enabled when "org.eclipse.jdt.ui.JavaActionSet" is enabled. "org.eclipse.jdt.ui.JavaActionSet" in its turn has Part Association defined as follows:

{code}
   <extension
         point="org.eclipse.ui.actionSetPartAssociations">
      <actionSetPartAssociation
            targetID="org.eclipse.jdt.ui.JavaActionSet">
         <part
               id="org.eclipse.jdt.ui.PackageExplorer">
         </part>
         <part
               id="org.eclipse.jdt.ui.TypeHierarchy">
         </part>
         <part
               id="org.eclipse.jdt.ui.CompilationUnitEditor">
         </part>
         <part
               id="org.eclipse.jdt.ui.ClassFileEditor">
         </part>
         <part
               id="org.eclipse.jdt.ui.PropertiesFileEditor">
         </part>
         <part
               id="org.eclipse.jdt.ui.ProjectsView">
         </part>
         <part
               id="org.eclipse.jdt.ui.PackagesView">
         </part>
         <part
               id="org.eclipse.jdt.ui.TypesView">
         </part>
         <part
               id="org.eclipse.jdt.ui.MembersView">
         </part>
         <part
               id="org.eclipse.jdt.ui.SourceView">
         </part>
         <part
               id="org.eclipse.jdt.callhierarchy.view">
         </part>
      </actionSetPartAssociation>
   </extension>
{code}
And it is enabled if any of these parts is active.

So, "Open Type" action will be visible in toolbar if any of associated View/Editor Parts is active.

                
      was (Author: vrubezhny):
    "Open Type is not visible when I open Git perspective." --- And?.. Can you make it visible by "Customize Perspective" dialog? 
(Right-click on toolbar and select "Customize Perspective" in pop-up menu, then find "Open Type" action and (if found, it should be grayed as "not enabled") try to check it to enable.)

On "selective enablement"... If I understand your question right:

The "Open Type" in JDT is enabled when "org.eclipse.jdt.ui.JavaActionSet" is enabled. "org.eclipse.jdt.ui.JavaActionSet" in its turn has Part Association defined as follows:

{code}
   <extension
         point="org.eclipse.ui.actionSetPartAssociations">
      <actionSetPartAssociation
            targetID="org.eclipse.jdt.ui.JavaActionSet">
         <part
               id="org.eclipse.jdt.ui.PackageExplorer">
         </part>
         <part
               id="org.eclipse.jdt.ui.TypeHierarchy">
         </part>
         <part
               id="org.eclipse.jdt.ui.CompilationUnitEditor">
         </part>
         <part
               id="org.eclipse.jdt.ui.ClassFileEditor">
         </part>
         <part
               id="org.eclipse.jdt.ui.PropertiesFileEditor">
         </part>
         <part
               id="org.eclipse.jdt.ui.ProjectsView">
         </part>
         <part
               id="org.eclipse.jdt.ui.PackagesView">
         </part>
         <part
               id="org.eclipse.jdt.ui.TypesView">
         </part>
         <part
               id="org.eclipse.jdt.ui.MembersView">
         </part>
         <part
               id="org.eclipse.jdt.ui.SourceView">
         </part>
         <part
               id="org.eclipse.jdt.callhierarchy.view">
         </part>
      </actionSetPartAssociation>
   </extension>
{code}
And it is enabled if any of these parts is active.

So, "Open Type" action will be visible in toolbar if any of associated View/Editor Parts is active.

So, we can make something like this for "Open Seam Component", but associations will be different. But this means that if any of associated part will be active then "Open Seam Component" button vill be visible and enabled in toolbar, otherwise it will be hidden and disabled (and cannot be enabled thru "Customize Perspective" dialog).

Don't know other ways to do enablement for toolbar/menu items.

There is method when handler is responsible to calculate its visibility (by specifying <visibleWhen checkEnabled="true" />). But in this case I don't know also how it can be made "invisible by default, but able to be made visible by "Customise Perspective". 
                  
> Seam toolbar items are showing up in the Teiid toolbar
> ------------------------------------------------------
>
>                 Key: JBIDE-7361
>                 URL: https://issues.jboss.org/browse/JBIDE-7361
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Seam 2, UpStream
>    Affects Versions: 3.2.0.Beta1
>         Environment: Fedora 12, JBDS 4.0.0 H52 with EDS
>            Reporter: Paul Nittel
>            Assignee: Victor Rubezhny
>             Fix For: 3.3.0.Beta1
>
>         Attachments: CannotEnableOpenTypeAction.png, jbide-7361.patch, Screenshot-SeamTools.png
>
>
> I was inspecting the toolbar to test actions when I noticed that there was no "Find Model Object" button. I did find the "Open Seam Component" and "Open Spring Bean" buttons, but I'm in the Teiid perspective.
> Even with the Seam perspective closed, there toolbar contains these buttons.
> Screenshot will be attached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira