[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-8474) Merge deltacloud trunk into maintenance 3.2.1

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-8474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584291#comment-12584291 ] 

Rob Stryker commented on JBIDE-8474:
------------------------------------

Another example of an improper change:

 
-	public static IHost createHost(String connectionName, String hostname, IRSESystemType systemType,
+	public static IHost createHost(String username, String connectionName, String hostname, IRSESystemType systemType,

In this case, you changed the method signature in RSEUtils.createHost(etc). The proper fix would have been
	public static IHost createHost(String connectionName, String hostname, IRSESystemType systemType,
+ 			ISystemRegistry systemRegistry) throws Exception {
+                return createHost(DeltaCloudRSEConstants.USERNAME, connectionName, hostName, systemType, systemRegistry);
+       }
+	public static IHost createHost(String username, String connectionName, String hostname, IRSESystemType 
 			ISystemRegistry systemRegistry) throws Exception {

In my fix, the original signature remains in the class and merely redirects to the new signature with a sensible default for the newly added parameter. 

> Merge deltacloud trunk into maintenance 3.2.1
> ---------------------------------------------
>
>                 Key: JBIDE-8474
>                 URL: https://issues.jboss.org/browse/JBIDE-8474
>             Project: Tools (JBoss Tools)
>          Issue Type: Task
>          Components: deltacloud
>    Affects Versions: 3.2.0.Final
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 3.2.1
>
>         Attachments: JBIDE-8474.patch
>
>
> All changes for deltacloud that have been pushed into trunk. 
> All issues that depend on this must be re-tested in the branch after applying the patch. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira