[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-8420) Connection wizard: PW is still presented in new connection dialog after I deleted it

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584306#comment-12584306 ] 

Rob Stryker commented on JBIDE-8420:
------------------------------------

If you look at the second commit made to this jira, you will see the following: patch url: http://fisheye.jboss.org/rdiff/JBossTools?csid=29154&u&N

-		boolean nameChanged = updateName(name);
+		boolean nameChanged = updateName(name); 

The two lines look the same, but the second line has a space added at the end. Files like this should be double-checked before committing to see if the change was relevant. While this particular commit was small, if larger commits are full of similar lines, it could make the patch confusing. Patches should be clean and only changing essential things. 



> Connection wizard: PW is still presented in new connection dialog after I deleted it
> ------------------------------------------------------------------------------------
>
>                 Key: JBIDE-8420
>                 URL: https://issues.jboss.org/browse/JBIDE-8420
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: deltacloud
>    Affects Versions: 3.2.0.CR1
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>             Fix For: 3.2.1, 3.3.0.M1
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira