[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-8250) connection wizard: authorisation error is reported in a dialog, title area says test was successful

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578107#comment-12578107 ] 

Andre Dietisheim commented on JBIDE-8250:
-----------------------------------------

the basic reason for this behavior is 2-fold:

1) Bad response from Deltacloud server
I request an unknown instance and provide the credentials you entered in the dialog. If I get 404 back, I know credentials are valid. If I get 403 back, I know that the credentials were invalid. If I get another error, I display it since this might be some other error: server timeouted, server crashed, etc.
The latest deltacloud server responds with 500 (internal server error) if I request an unknown resource while using invalid credentials. I expect 403. I reported this to the deltacloud jira https://issues.apache.org/jira/browse/DTACLOUD-14.

2) Any error-response should show "connection test failed" in the title area
I did only treat 403 response as connection failure. All other cases (other errors, too) were treated as connection successful.

I provided a 1-liner patch since I belive that the error-dialog should still appear on any error-response that is not 403. 

> connection wizard: authorisation error is reported in a dialog, title area says test was successful
> ---------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-8250
>                 URL: https://issues.jboss.org/browse/JBIDE-8250
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: deltacloud
>    Affects Versions: 3.2.0.CR1
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>             Fix For: 3.2.0.CR2 (tentative)
>
>         Attachments: autorization-error.png
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira