[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-8548) Support auto discovery of remote processes for debugging

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-8548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614097#comment-12614097 ] 

Max Rydahl Andersen commented on JBIDE-8548:
--------------------------------------------

>I will create the UI as you required.

Coo :)

>>>The plugin creates a configuration (the default)

>>Currently it creates a custom type of launch - which really is not necessary and dilutes the purpose imo

>> Marked as "default" is redundant - why is that there? Why not search the existing >>remote launches and use that if it fits the same criteria ? i.e. project selection, port >>etc. ?

>>I wanted to enable the user to select more projects that would be added as the default >>attachment. The Eclipse's Remote Java Application configuration adds only the first >>selected project. This can also be performed by changing a source path computer of the >>Eclipse's Remote Java Application configuration, but that would be changing the standard >>Eclipse Remote Configuration.

hmm - I can add multiple projects to eclipse remote java applications - why can't we do that too ?

>"project selection, port" aren't the only criterias when selecting some configuration.

No, I know that - the list is not complete.

 >The user can also use some additional source attachments that there aren't in his >workspace. For example, when the user tests Arquillian on JBoss AS, he will want to add >some libraries from JBoss AS, when testing it on Glassfish, he will want to add Glassfish >libraries ... The user will create separate configurations on JBoss AS and Glassfish, but >how to choose what configuration to launch?

But the "default" doesn't help here..."default" would only work for one configuration.

If there is a need to choose others - then again if you search for matching ports/project selection then you can show a list with configurations with best matches or similar.

>What will the plugin do if it can't find a corresponding "project selection, port"?
>Would we create a different configuration for every "project selection, port" >combination? That would mean creating a lot of launch configurations.

You only create launch configs for those you have launched.

>Would we change an existing remote configuration? When using the standard Eclipse Remote >Java Application configuration, we mustn't change it because we can't know if the user >has created it for other purpose.

You can add a variable to the launch config to mark it.

>It is likely that adding some new potential feature to this plugin won't be possible to >do using the standard Eclipse remote configuration.

What features would that be ? 

>That's why I have created a separate type of a launch configuration. It is similar to the >standard Eclipse remote configuration, but has a separate source path computer. This way, >we can add all selected projects to the default attachment and create a separate Launch >Configuration dialog.

What does the separate sourc path computer provides that adding the projects explicitly does not ?

>The "default" launch configuration is created if there isn't any JBoss remote launch >configuration.
>The user can create more different configurations in order to be able to add different >source attachments for different applications.
>When starting debugging automatically (using a menu or shortcut), the plugin uses a >configuration that he marks as the default. The plugin checks and, if necessary, changes >the selected projects and the port of that configuration and launches the configuration. >The user's additional source attachments won't be changed.

If you created this to support users with multiple launches then why this singular "default"?

Why not just see if there is a perfect match and use that as the default; and provide a "or use <combo of existing configs sorted by those having a 'used by automatic remote launches' ?
 
Note, I'm getting where you are trying to go with separate config but since that is adding alot of more complexity and makes this feature even harder to contribute back to original eclipse I would like to challenge it to be sure we really need it.



> Support auto discovery of remote processes for debugging
> --------------------------------------------------------
>
>                 Key: JBIDE-8548
>                 URL: https://issues.jboss.org/browse/JBIDE-8548
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: JBossAS
>            Reporter: Aslak Knutsen
>            Assignee: Snjezana Peco
>             Fix For: 3.3.0.M3, 3.3.x
>
>         Attachments: 8548-1.png, 8548-2.png, 8548-3.png, jbide-8548d.png, lsof.txt, org.jboss.tools.remote.debug.zip, org.jboss.tools.remote.debug1.zip, org.jboss.tools.remote.debug2.zip, remote_java_application.bmml
>
>
> It would be helpful if Eclipse could provide a 'debug as' with auto discover of local java processes, somewhat like jconsole does. Eclipse should also auto associate the debug session with the current project. 
> 'debug as' -> 'remote process x'

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira