[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-9054) Improve current code by minimalistic refactorings without functional change

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614686#comment-12614686 ] 

Rob Stryker commented on JBIDE-9054:
------------------------------------

70+ commits, many of only one file, all targeted to the same jira, spread throughout the entire codebase. This really is not useful and is very hard to handle. If we are to have general code-cleanup they must be split by functionality.  Publishing / Launching / Polling / Classpaths / Etc.  

Having everything and the kitchen sink committed to one JIRA is the same as having no JIRA really. 

Furthermore, we are typically required to smoketest before each commit. Making 70+ commits means 70+ smoketests, and is probably not efficient. Also I doubt the smoke tests are being done, since the most recent regression actually broke launching of jboss-5 servers. It is much better to refactor, say, polling first. Refactor all 5 or 6 polling classes, and then do one smoke test, and commit all 5-6 files and any new utility classes at once. This should get its own JIRA, which may be a related / CHILD jira to this one. 

We need to find a way to make this refactor more coherent and understandable for all. 

> Improve current code by minimalistic refactorings without functional change
> ---------------------------------------------------------------------------
>
>                 Key: JBIDE-9054
>                 URL: https://issues.jboss.org/browse/JBIDE-9054
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS
>    Affects Versions: 3.3.0.M1
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>             Fix For: 3.3.x
>
>
> This issue is about minimalistic refactorings that shall improve code readability. It covers 
> * extracting methods out of larger code blocks 
> * renaming methods
> * renaming local variables

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira